GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp: Remove bogus SMRAM locking 

From tests this does not lock down SMRAM and it's also not possible to
read back what is written, be it via PCI mmconfig or io ops. The
FSP integration can be assumed to be bogus on this point.

Change-Id: Ia0526774f7b201d2a3c0eefb578bf0a19dae9212
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51532
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans 2021-03-16 16:27:27 +01:00
parent c8116f6ea0
commit be2f937f1e
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/intel/xeon_sp/cpx/chip.c
View File

@ -182,14 +182,6 @@ static void chip_final(void *data)
/* LOCK PAM */ /* LOCK PAM */
pci_or_config32(pcidev_path_on_root(PCI_DEVFN(0, 0)), 0x80, 1 << 0); pci_or_config32(pcidev_path_on_root(PCI_DEVFN(0, 0)), 0x80, 1 << 0);
/*
* LOCK SMRAM
* According to the CedarIsland FSP Integration Guide this needs to
* be done with legacy 0xCF8/0xCFC IO ops.
*/
uint8_t reg8 = pci_io_read_config8(PCI_DEV(0, 0, 0), 0x88);
pci_io_write_config8(PCI_DEV(0, 0, 0), 0x88, reg8 | (1 << 4));
mp_run_on_all_cpus(set_msr_locks, NULL); mp_run_on_all_cpus(set_msr_locks, NULL);
set_pcu_locks(); set_pcu_locks();
set_imc_locks(); set_imc_locks();