ACPI: Use common OperationRegion for PCI_MMCONF

Change-Id: Iadb4c3c77ecda4df8e48415d246e769ede2ce86d
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50648
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki 2021-02-14 06:58:39 +02:00
parent c92efa3363
commit c0733e1639
6 changed files with 14 additions and 18 deletions

View File

@ -32,9 +32,14 @@ Method (_PIC, 1)
} }
#if CONFIG(MMCONF_SUPPORT) #if CONFIG(MMCONF_SUPPORT)
/* Base address of PCIe config space */ Scope(\_SB) {
Name(PCBA, CONFIG_MMCONF_BASE_ADDRESS) /* Base address of PCIe config space */
Name(PCBA, CONFIG_MMCONF_BASE_ADDRESS)
/* Length of PCIe config space, 1MB each bus */ /* Length of PCIe config space, 1MB each bus */
Name(PCLN, CONFIG_MMCONF_LENGTH) Name(PCLN, CONFIG_MMCONF_LENGTH)
/* PCIe Configuration Space */
OperationRegion(PCFG, SystemMemory, PCBA, PCLN) /* Each bus consumes 1MB */
}
#endif #endif

View File

@ -1,7 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* PCIe Configuration Space for CONFIG_MMCONF_BUS_NUMBER busses */
OperationRegion(PCFG, SystemMemory, PCBA, PCLN) /* Each bus consumes 1MB */
Field(PCFG, ByteAcc, NoLock, Preserve) { Field(PCFG, ByteAcc, NoLock, Preserve) {
/* Byte offsets are computed using the following technique: /* Byte offsets are computed using the following technique:
* ((bus number + 1) * ((device number * 8) * 4096)) + register offset * ((bus number + 1) * ((device number * 8) * 4096)) + register offset

View File

@ -284,8 +284,7 @@ Field( SMIC, ByteAcc, NoLock, Preserve) {
PGA3, 8 , PGA3, 8 ,
} }
OperationRegion(FCFG, SystemMemory, PCBA, 0x01000000) Field(PCFG, DwordAcc, NoLock, Preserve)
Field(FCFG, DwordAcc, NoLock, Preserve)
{ {
/* XHCI */ /* XHCI */
Offset(0x00080010), /* Base address */ Offset(0x00080010), /* Base address */

View File

@ -1,7 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* PCIe Configuration Space for CONFIG_MMCONF_BUS_NUMBER busses */
OperationRegion(PCFG, SystemMemory, PCBA, PCLN) /* Each bus consumes 1MB */
Field(PCFG, ByteAcc, NoLock, Preserve) { Field(PCFG, ByteAcc, NoLock, Preserve) {
/* Byte offsets are computed using the following technique: /* Byte offsets are computed using the following technique:
* ((bus number + 1) * ((device number * 8) * 4096)) + register offset * ((bus number + 1) * ((device number * 8) * 4096)) + register offset

View File

@ -29,8 +29,6 @@ Scope(\) {
} }
Scope(\_SB) { Scope(\_SB) {
/* PCIe Configuration Space for 16 busses */
OperationRegion(PCFG, SystemMemory, PCBA, 0x01000000) /* Each bus consumes 1MB */
Field(PCFG, ByteAcc, NoLock, Preserve) { Field(PCFG, ByteAcc, NoLock, Preserve) {
/* Byte offsets are computed using the following technique: /* Byte offsets are computed using the following technique:
* ((bus number + 1) * ((device number * 8) * 4096)) + register offset * ((bus number + 1) * ((device number * 8) * 4096)) + register offset

View File

@ -1,7 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
/* PCIe Configuration Space for CONFIG_MMCONF_BUS_NUMBER busses */
OperationRegion(PCFG, SystemMemory, PCBA, PCLN) /* Each bus consumes 1MB */
Field(PCFG, ByteAcc, NoLock, Preserve) { Field(PCFG, ByteAcc, NoLock, Preserve) {
/* Byte offsets are computed using the following technique: /* Byte offsets are computed using the following technique:
* ((bus number + 1) * ((device number * 8) * 4096)) + register offset * ((bus number + 1) * ((device number * 8) * 4096)) + register offset