GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/i82801dx: Drop APM_CNT_GNVS_UPDATE 

In commit 96cb252 the accompanying implementation
of smm_setup_structures() was already dropped.

Change-Id: I9cff0cbaa85cf771cc7761b6c5286ec34a76ee9a
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42425
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki 2020-06-16 14:31:05 +03:00 committed by Patrick Georgi
parent b486f29a44
commit c4ef8e4c2b
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/southbridge/intel/i82801dx/smihandler.c
View File

@ -25,7 +25,6 @@
* initialize it with a sane value
*/
u16 pmbase = PMBASE_ADDR;
u8 smm_initialized = 0;
unsigned char *mbi = NULL;
u32 mbi_len;
@ -362,17 +361,6 @@ static void southbridge_smi_apmc(void)
outl(pmctrl, pmbase + PM1_CNT);
printk(BIOS_DEBUG, "SMI#: ACPI enabled.\n");
break;
case APM_CNT_GNVS_UPDATE:
if (smm_initialized) {
printk(BIOS_DEBUG, "SMI#: SMM structures already initialized!\n");
return;
}
gnvs = *(global_nvs_t **)0x500;
tcg = *(void **)0x504;
smi1 = *(void **)0x508;
smm_initialized = 1;
printk(BIOS_DEBUG, "SMI#: Setting up structures to %p, %p, %p\n", gnvs, tcg, smi1);
break;
case APM_CNT_MBI_UPDATE: // FIXME
if (mbi_initialized) {
printk(BIOS_DEBUG, "SMI#: mbi already registered!\n");