nb/intel: Don't select VBOOT_SEPARATE_VERSTAGE

Now the bootblock is not limited to 64K so integrating vboot into the
bootblock reduces the binary size.

Change-Id: Ic92ecf8068f327a893d20924685ce571752d379f
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52787
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans 2021-04-30 15:19:24 +02:00 committed by Patrick Georgi
parent b761903b8b
commit c8116f6ea0
10 changed files with 4 additions and 12 deletions

View File

@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS
config VBOOT config VBOOT
select VBOOT_MUST_REQUEST_DISPLAY select VBOOT_MUST_REQUEST_DISPLAY
select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_STARTS_IN_BOOTBLOCK
select VBOOT_SEPARATE_VERSTAGE
select VBOOT_VBNV_CMOS select VBOOT_VBNV_CMOS
select VBOOT_NO_BOARD_SUPPORT select VBOOT_NO_BOARD_SUPPORT
select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_LID_SHUTDOWN

View File

@ -20,7 +20,6 @@ config BOARD_SPECIFIC_OPTIONS
config VBOOT config VBOOT
select VBOOT_MUST_REQUEST_DISPLAY select VBOOT_MUST_REQUEST_DISPLAY
select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_STARTS_IN_BOOTBLOCK
select VBOOT_SEPARATE_VERSTAGE
select VBOOT_VBNV_CMOS select VBOOT_VBNV_CMOS
select VBOOT_NO_BOARD_SUPPORT if !CHROMEOS select VBOOT_NO_BOARD_SUPPORT if !CHROMEOS
select GBB_FLAG_DISABLE_LID_SHUTDOWN select GBB_FLAG_DISABLE_LID_SHUTDOWN

View File

@ -4,7 +4,7 @@ bootblock-y += bootblock.c
romstage-$(CONFIG_CHROMEOS) += chromeos.c romstage-$(CONFIG_CHROMEOS) += chromeos.c
ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-$(CONFIG_CHROMEOS) += chromeos.c
verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += chromeos.c verstage-y += chromeos.c
ramstage-y += lan.c ramstage-y += lan.c
smm-y += variants/$(VARIANT_DIR)/led.c smm-y += variants/$(VARIANT_DIR)/led.c

View File

@ -4,4 +4,4 @@ romstage-y += gpio.c
romstage-y += chromeos.c romstage-y += chromeos.c
ramstage-y += chromeos.c ramstage-y += chromeos.c
verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += chromeos.c verstage-y += chromeos.c

View File

@ -16,7 +16,6 @@ config NORTHBRIDGE_SPECIFIC_OPTIONS
config VBOOT config VBOOT
select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_STARTS_IN_BOOTBLOCK
select VBOOT_SEPARATE_VERSTAGE
config CBFS_SIZE config CBFS_SIZE
hex hex

View File

@ -14,7 +14,6 @@ config HASWELL_VBOOT_IN_BOOTBLOCK
bool "Start verstage in bootblock" bool "Start verstage in bootblock"
default y default y
select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_STARTS_IN_BOOTBLOCK
select VBOOT_SEPARATE_VERSTAGE
help help
Haswell can either start verstage in a separate stage Haswell can either start verstage in a separate stage
right after the bootblock has run or it can start it right after the bootblock has run or it can start it

View File

@ -17,8 +17,6 @@ config NORTHBRIDGE_SPECIFIC_OPTIONS
config VBOOT config VBOOT
select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_STARTS_IN_BOOTBLOCK
select VBOOT_SEPARATE_VERSTAGE
config NORTHBRIDGE_INTEL_SUBTYPE_I945GC config NORTHBRIDGE_INTEL_SUBTYPE_I945GC
def_bool n def_bool n
config NORTHBRIDGE_INTEL_SUBTYPE_I945GM config NORTHBRIDGE_INTEL_SUBTYPE_I945GM

View File

@ -14,7 +14,6 @@ if NORTHBRIDGE_INTEL_IRONLAKE
config VBOOT config VBOOT
select VBOOT_MUST_REQUEST_DISPLAY select VBOOT_MUST_REQUEST_DISPLAY
select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_STARTS_IN_BOOTBLOCK
select VBOOT_SEPARATE_VERSTAGE
# CPU is reset without platform/TPM during romstage # CPU is reset without platform/TPM during romstage
select TPM_STARTUP_IGNORE_POSTINIT select TPM_STARTUP_IGNORE_POSTINIT

View File

@ -21,7 +21,6 @@ config SANDYBRIDGE_VBOOT_IN_BOOTBLOCK
bool "Start verstage in bootblock" bool "Start verstage in bootblock"
default y default y
select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_STARTS_IN_BOOTBLOCK
select VBOOT_SEPARATE_VERSTAGE
help help
Sandy Bridge can either start verstage in a separate stage Sandy Bridge can either start verstage in a separate stage
right after the bootblock has run or it can start it right after the bootblock has run or it can start it

View File

@ -41,10 +41,10 @@ ifeq ($(CONFIG_INTEL_LYNXPOINT_LP),y)
romstage-y += lp_gpio.c romstage-y += lp_gpio.c
ramstage-y += lp_gpio.c ramstage-y += lp_gpio.c
smm-y += lp_gpio.c smm-y += lp_gpio.c
verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += lp_gpio.c verstage-y += lp_gpio.c
endif endif
verstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += pmutil.c verstage-y += pmutil.c
CPPFLAGS_common += -I$(src)/southbridge/intel/lynxpoint/include CPPFLAGS_common += -I$(src)/southbridge/intel/lynxpoint/include