GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/guybrush: Use open drain eSPI alerts 

Remove the override in guybrush devicetree that configured in-band eSPI
alerts. This will result in guybrush using dedicated open-drain eSPI
alerts. Guybrush boards must be reworked to connect the eSPI alert line,
otherwise they will not boot with this change

BUG=b:198596430
TEST=Boot on reworked guybrush
BRANCH=None

Change-Id: I185eec773336fb662d9fe7f4c11991813e4d7cd6
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57778
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Rob Barnes 2021-09-20 07:17:40 -06:00 committed by Paul Fagerburg
parent f894fcc031
commit c9686d22b1
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/guybrush/variants/guybrush/overridetree.cb
View File

@ -169,7 +169,4 @@ chip soc/amd/cezanne
end
end
# TODO(b/198596430): Disable in-band alerts after majority boards are reworked
register "common_config.espi_config.alert_pin" = "ESPI_ALERT_PIN_IN_BAND"
end # chip soc/amd/cezanne