devicetree: Rename unused parameter to passthru
The actual use of the parameter max is to keep track of PCI bus number while recursively scanning PCI bridges or PCI-e rootports. Neither CPU, SMBus, LPC or other static buses are involved in this enumeration, but the way bridge operations were originally designed forced to pass this argument thru unrelated functions. Follow-up removes these once the function prototype gets fixed. Change-Id: Idbc9c515a362c571a1798bb36972058b309c2774 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/8535 Tested-by: build bot (Jenkins) Reviewed-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
This commit is contained in:
parent
d0e212cdce
commit
cd37a2ba41
|
@ -49,7 +49,7 @@ const char mainboard_name[] = CONFIG_MAINBOARD_VENDOR " " CONFIG_MAINBOARD_PART_
|
|||
* @return The largest bus number used.
|
||||
*/
|
||||
|
||||
static unsigned int scan_static_bus(device_t bus, unsigned int max)
|
||||
static unsigned int scan_static_bus(device_t bus, unsigned int passthru)
|
||||
{
|
||||
device_t child;
|
||||
struct bus *link;
|
||||
|
@ -68,21 +68,21 @@ static unsigned int scan_static_bus(device_t bus, unsigned int max)
|
|||
}
|
||||
}
|
||||
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
unsigned int scan_lpc_bus(device_t bus, unsigned int max)
|
||||
unsigned int scan_lpc_bus(device_t bus, unsigned int passthru)
|
||||
{
|
||||
printk(BIOS_SPEW, "%s for %s\n", __func__, dev_path(bus));
|
||||
|
||||
max = scan_static_bus(bus, max);
|
||||
scan_static_bus(bus, 0);
|
||||
|
||||
printk(BIOS_SPEW, "%s for %s done\n", __func__, dev_path(bus));
|
||||
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
unsigned int scan_smbus(device_t bus, unsigned int max)
|
||||
unsigned int scan_smbus(device_t bus, unsigned int passthru)
|
||||
{
|
||||
device_t child;
|
||||
struct bus *link;
|
||||
|
@ -112,7 +112,7 @@ unsigned int scan_smbus(device_t bus, unsigned int max)
|
|||
|
||||
printk(BIOS_SPEW, "%s for %s done\n", __func__, dev_path(bus));
|
||||
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -124,14 +124,15 @@ unsigned int scan_smbus(device_t bus, unsigned int max)
|
|||
* @param max The current bus number scanned so far, usually 0x00.
|
||||
* @return The largest bus number used.
|
||||
*/
|
||||
static unsigned int root_dev_scan_bus(device_t bus, unsigned int max)
|
||||
static unsigned int root_dev_scan_bus(device_t bus, unsigned int passthru)
|
||||
{
|
||||
device_t child;
|
||||
struct bus *link;
|
||||
unsigned int max = 0;
|
||||
|
||||
printk(BIOS_SPEW, "%s for %s\n", __func__, dev_path(bus));
|
||||
|
||||
max = scan_static_bus(bus, max);
|
||||
scan_static_bus(bus, 0);
|
||||
|
||||
for (link = bus->link_list; link; link = link->next) {
|
||||
for (child = link->children; child; child = child->sibling) {
|
||||
|
@ -144,7 +145,7 @@ static unsigned int root_dev_scan_bus(device_t bus, unsigned int max)
|
|||
|
||||
printk(BIOS_SPEW, "%s for %s done\n", __func__, dev_path(bus));
|
||||
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void root_dev_reset(struct bus *bus)
|
||||
|
|
|
@ -241,7 +241,7 @@ static void cpu_bus_init(device_t dev)
|
|||
initialize_cpus(dev->link_list);
|
||||
}
|
||||
|
||||
static unsigned int cpu_bus_scan(device_t bus, unsigned int max)
|
||||
static unsigned int cpu_bus_scan(device_t bus, unsigned int passthru)
|
||||
{
|
||||
int max_cpus = fw_cfg_max_cpus();
|
||||
device_t cpu;
|
||||
|
|
|
@ -1010,7 +1010,7 @@ static void add_more_links(device_t dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1186,7 +1186,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
|
@ -765,7 +765,7 @@ static void domain_enable_resources(device_t dev)
|
|||
|
||||
/* Bus related code */
|
||||
|
||||
static u32 cpu_bus_scan(struct device *dev, u32 max)
|
||||
static u32 cpu_bus_scan(struct device *dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus = dev->link_list;
|
||||
device_t cpu;
|
||||
|
@ -784,7 +784,7 @@ static u32 cpu_bus_scan(struct device *dev, u32 max)
|
|||
if (cpu)
|
||||
amd_cpu_topology(cpu, 0, apic_id);
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
|
@ -1009,7 +1009,7 @@ static void add_more_links(device_t dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1185,7 +1185,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
|
@ -992,7 +992,7 @@ static void add_more_links(struct device *dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1166,7 +1166,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(struct device *dev)
|
||||
|
|
|
@ -991,7 +991,7 @@ static void add_more_links(device_t dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1165,7 +1165,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
|
@ -1008,7 +1008,7 @@ static void add_more_links(device_t dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1182,7 +1182,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
|
@ -1180,7 +1180,7 @@ static void add_more_links(device_t dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1319,7 +1319,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
|
@ -985,7 +985,7 @@ static void add_more_links(device_t dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1176,7 +1176,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
|
@ -1001,7 +1001,7 @@ static void add_more_links(device_t dev, unsigned total_links)
|
|||
last->next = NULL;
|
||||
}
|
||||
|
||||
static u32 cpu_bus_scan(device_t dev, u32 max)
|
||||
static u32 cpu_bus_scan(device_t dev, u32 passthru)
|
||||
{
|
||||
struct bus *cpu_bus;
|
||||
device_t dev_mc;
|
||||
|
@ -1187,7 +1187,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
|
|||
amd_cpu_topology(cpu, i, j);
|
||||
} //j
|
||||
}
|
||||
return max;
|
||||
return passthru;
|
||||
}
|
||||
|
||||
static void cpu_bus_init(device_t dev)
|
||||
|
|
Loading…
Reference in New Issue