src: include <assert.h> when appropriate

Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/26796
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: David Guckian

src/arch/arm64/arm_tf.c

@@ -18,7 +18,6 @@
 #include <arch/mmu.h>
 #include <arch/transition.h>
 #include <arm_tf.h>
-#include <assert.h>
 #include <bootmem.h>
 #include <cbfs.h>
 #include <console/console.h>

src/arch/x86/acpigen.c

@@ -28,6 +28,7 @@
 #include <lib.h>
 #include <string.h>
 #include <arch/acpigen.h>
+#include <assert.h>
 #include <console/console.h>
 #include <device/device.h>
 

src/arch/x86/include/arch/acpigen.h

@@ -18,7 +18,6 @@
 #ifndef LIBACPI_H
 #define LIBACPI_H
 
-#include <assert.h>
 #include <stdlib.h>
 #include <stdint.h>
 #include <arch/acpi.h>

src/commonlib/storage/pci_sdhci.c

@@ -18,7 +18,6 @@
 #endif
 
 #include <arch/early_variables.h>
-#include <assert.h>
 #include <commonlib/sdhci.h>
 #include <device/pci.h>
 #include <device/pci_ops.h>

src/commonlib/storage/sd.c

@@ -19,7 +19,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <commonlib/sd_mmc_ctrlr.h>
 #include <commonlib/storage.h>
 #include <delay.h>

src/commonlib/storage/sd_mmc.c

@@ -20,7 +20,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <commonlib/storage.h>
 #include <delay.h>
 #include <endian.h>

src/commonlib/storage/sdhci.c

@@ -17,7 +17,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include "bouncebuf.h"
 #include <commonlib/sd_mmc_ctrlr.h>
 #include <commonlib/sdhci.h>

src/commonlib/storage/sdhci_adma.c

@@ -17,7 +17,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <commonlib/sdhci.h>
 #include <commonlib/storage.h>
 #include <console/console.h>

src/commonlib/storage/storage.c

@@ -21,7 +21,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <commonlib/storage.h>
 #include "sd_mmc.h"
 #include "storage.h"

src/cpu/intel/hyperthreading/intel_sibling.c

@@ -17,7 +17,6 @@
 #include <device/device.h>
 #include <pc80/mc146818rtc.h>
 #include <smp/spinlock.h>
-#include <assert.h>
 
 #if CONFIG(PARALLEL_CPU_INIT)
 #error Intel hyper-threading requires serialized CPU init

src/cpu/intel/model_206ax/model_206ax_init.c

@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <device/device.h>
 #include <arch/acpi.h>

src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <cpu/cpu.h>
 #include <cpu/x86/mp.h>

src/drivers/spi/winbond.c

@@ -18,7 +18,6 @@
 #include <spi_flash.h>
 #include <spi-generic.h>
 #include <string.h>
-#include <assert.h>
 #include <delay.h>
 #include <lib.h>
 

src/lib/gpio.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <base3.h>
 #include <console/console.h>
 #include <delay.h>

src/mainboard/google/dragonegg/romstage_fsp_params.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <baseboard/variants.h>
 #include <soc/romstage.h>
 

src/mainboard/intel/galileo/vboot.c

@@ -12,7 +12,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <bootmode.h>
 #include <device/i2c_simple.h>
 #include <soc/i2c.h>

src/northbridge/amd/pi/00630F01/northbridge.c

@@ -33,7 +33,6 @@
 #include <cpu/amd/msr.h>
 #include <cpu/amd/mtrr.h>
 #include <arch/acpigen.h>
-#include <assert.h>
 #include <northbridge/amd/pi/nb_common.h>
 #include <northbridge/amd/agesa/agesa_helper.h>
 #if CONFIG(BINARYPI_LEGACY_WRAPPER)

src/security/vboot/vbnv_flash.c

@@ -14,7 +14,6 @@
  */
 
 #include <arch/early_variables.h>
-#include <assert.h>
 #include <commonlib/region.h>
 #include <console/console.h>
 #include <string.h>

src/soc/cavium/cn81xx/ecam0.c

@@ -23,7 +23,6 @@
 #include <soc/addressmap.h>
 #include <soc/cavium/common/pci/chip.h>
 #include <soc/ecam.h>
-#include <assert.h>
 
 #define CAVM_PCCPF_XXX_VSEC_CTL 0x108
 #define CAVM_PCCPF_XXX_VSEC_SCTL 0x10c

src/soc/cavium/cn81xx/twsi.c

@@ -20,7 +20,6 @@
 #include <soc/clock.h>
 #include <device/i2c.h>
 #include <device/i2c_simple.h>
-#include <assert.h>
 #include <delay.h>
 #include <device/mmio.h>
 #include <soc/addressmap.h>

src/soc/cavium/common/ecam.c

@@ -22,7 +22,6 @@
 #include <device/pci.h>
 #include <soc/addressmap.h>
 #include <soc/ecam.h>
-#include <assert.h>
 
 /**
  * Get PCI BAR address from cavium specific extended capability.

src/soc/intel/apollolake/acpi.c

@@ -21,6 +21,7 @@
 #include <console/console.h>
 #include <device/mmio.h>
 #include <arch/smp/mpspec.h>
+#include <assert.h>
 #include <device/pci_ops.h>
 #include <cbmem.h>
 #include <cpu/x86/smm.h>

src/soc/intel/apollolake/gpio_apl.c

@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <intelblocks/gpio.h>
 #include <intelblocks/pcr.h>
 #include <soc/pcr_ids.h>

src/soc/intel/apollolake/gpio_glk.c

@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <intelblocks/gpio.h>
 #include <intelblocks/pcr.h>
 #include <soc/pcr_ids.h>

src/soc/intel/apollolake/uart.c

@@ -20,7 +20,6 @@
  * shouldn't cause any fragmentation.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <intelblocks/uart.h>
 #include <soc/gpio.h>

src/soc/intel/cannonlake/romstage/romstage.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <chip.h>
 #include <cpu/x86/mtrr.h>
 #include <cbmem.h>

src/soc/intel/cannonlake/uart.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <device/pci_def.h>
 #include <intelblocks/gpio.h>

src/soc/intel/common/block/sgx/sgx.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <cpu/x86/msr.h>
 #include <cpu/x86/mtrr.h>

src/soc/intel/common/block/uart/uart.c

@@ -14,7 +14,6 @@
  */
 
 #include <arch/acpi.h>
-#include <assert.h>
 #include <cbmem.h>
 #include <console/uart.h>
 #include <device/device.h>

src/soc/intel/denverton_ns/gpio.c

@@ -16,7 +16,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <intelblocks/gpio.h>
 #include <intelblocks/pcr.h>
 #include <soc/pcr.h>

src/soc/intel/icelake/romstage/romstage.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <chip.h>
 #include <cpu/x86/mtrr.h>
 #include <cbmem.h>

src/soc/intel/icelake/uart.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <device/pci_def.h>
 #include <intelblocks/gpio.h>

src/soc/intel/quark/spi.c

@@ -16,7 +16,6 @@
 
 #include <device/mmio.h>
 #include <device/pci_ops.h>
-#include <assert.h>
 #include <bootstate.h>
 #include <console/console.h>
 #include <device/pci_ids.h>

src/soc/intel/skylake/cpu.c

@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <arch/cpu.h>
 #include <bootstate.h>
 #include <console/console.h>

src/soc/intel/skylake/gpio.c

@@ -14,7 +14,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <intelblocks/gpio.h>
 #include <intelblocks/pcr.h>
 #include <soc/pcr_ids.h>

src/soc/mediatek/common/include/soc/rtc_common.h

@@ -16,7 +16,6 @@
 #ifndef SOC_MEDIATEK_RTC_COMMON_H
 #define SOC_MEDIATEK_RTC_COMMON_H
 
-#include <assert.h>
 #include <bcd.h>
 #include <console/console.h>
 #include <rtc.h>

src/soc/mediatek/common/pmic_wrap.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <soc/pmic_wrap.h>
 #include <timer.h>
 

src/soc/mediatek/mt8173/dramc_pi_calibration_api.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <console/console.h>
 #include <stdlib.h>
 #include <soc/addressmap.h>

src/soc/mediatek/mt8173/emi.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <boardid.h>
 #include <console/console.h>
 #include <soc/addressmap.h>

src/soc/mediatek/mt8173/pmic_wrap.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <console/console.h>
 #include <delay.h>
 #include <soc/infracfg.h>

src/soc/mediatek/mt8183/mt6358.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <soc/pmic_wrap.h>
 #include <soc/mt6358.h>

src/soc/qualcomm/ipq40xx/i2c.c

@@ -29,7 +29,6 @@
  * IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <device/i2c_simple.h>
 #include <stdlib.h>

src/soc/qualcomm/ipq806x/i2c.c

@@ -27,7 +27,6 @@
  * SUCH DAMAGE.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <device/i2c_simple.h>
 #include <stdlib.h>

src/soc/rockchip/common/edp.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <console/console.h>
 #include <delay.h>
 #include <device/device.h>

src/soc/rockchip/common/pwm.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <soc/addressmap.h>
 #include <soc/grf.h>
 #include <soc/soc.h>

src/soc/rockchip/rk3288/hdmi.c

@@ -20,7 +20,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <console/console.h>
 #include <delay.h>
 #include <edid.h>

src/soc/rockchip/rk3288/tsadc.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <soc/clock.h>
 #include <soc/grf.h>
 #include <soc/pmu.h>

src/soc/rockchip/rk3399/bl31_plat_params.c

@@ -15,7 +15,6 @@
  */
 
 #include <arm_tf.h>
-#include <assert.h>
 #include <cbmem.h>
 #include <soc/bl31_plat_params.h>
 

src/soc/rockchip/rk3399/mipi.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <console/console.h>
 #include <delay.h>
 #include <device/device.h>

src/soc/rockchip/rk3399/tsadc.c

@@ -14,7 +14,6 @@
  */
 
 #include <device/mmio.h>
-#include <assert.h>
 #include <delay.h>
 #include <soc/clock.h>
 #include <soc/grf.h>

src/soc/samsung/exynos5250/alternate_cbfs.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <boot_device.h>
 #include <console/console.h>
 #include <soc/alternate_cbfs.h>

src/soc/samsung/exynos5250/pinmux.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <console/console.h>
 #include <soc/gpio.h>
 #include <soc/pinmux.h>

src/soc/samsung/exynos5420/alternate_cbfs.c

@@ -14,7 +14,6 @@
  */
 
 #include <arch/cache.h>
-#include <assert.h>
 #include <boot_device.h>
 #include <console/console.h>
 #include <soc/alternate_cbfs.h>

src/soc/samsung/exynos5420/pinmux.c

@@ -13,7 +13,6 @@
  * GNU General Public License for more details.
  */
 
-#include <assert.h>
 #include <soc/gpio.h>
 #include <soc/pinmux.h>
 #include <stdlib.h>

src/superio/renesas/m3885x/superio.c

@@ -17,7 +17,6 @@
 #include <device/pnp.h>
 #include <console/console.h>
 #include <device/smbus.h>
-#include <assert.h>
 #include <stdlib.h>
 #include <pc80/keyboard.h>
 

src/superio/smsc/lpc47n227/early_serial.c

@@ -17,7 +17,9 @@
 /* Pre-RAM driver for SMSC LPC47N227 Super I/O chip. */
 
 #include <arch/io.h>
+#include <assert.h>
 #include <device/pnp_ops.h>
+
 #include "lpc47n227.h"
 
 void pnp_enter_conf_state(pnp_devfn_t dev)