GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/ipmi: Add CONFIG_IPMI_KCS_TIMEOUT_MS for IPMI KCS timeout value 

With the current timeout of 1000 cycles of 100 microsecond would see
timeout occurs on OCP Delta Lake if the log level is set to values
smaller than 8. Because the prink(BIOS_SPEW, ..) in ipmi_kcs_status()
creates delay and avoid the problem, but after setting the log level
to 4 we see some timeout occurs.

The unit is millisecond and the default value is set to 5000 according
to IPMI spec v2.0 rev 1.1 Sec. 9.15, a five-second timeout or greater
is recommended.

Tested=On OCP Delta Lake, with log level 4 cannot observe timeout
occurs.

Change-Id: I42ede1d9200bb5d0dbb455d2ff66e2816f10e86b
Signed-off-by: Johnny Lin <johnny_lin@wiwynn.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45103
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Johnny Lin 2020-09-04 17:05:58 +08:00 committed by Patrick Georgi
parent 44097e21cc
commit d04c06b472
2 changed files with 22 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/drivers/ipmi/Kconfig
View File

@ -33,3 +33,12 @@ config BMC_KCS_BASE
help help
The PNP base address of BMC KCS. It must be equal to the The PNP base address of BMC KCS. It must be equal to the
pnp port value defined in devicetree for chip drivers/ipmi. pnp port value defined in devicetree for chip drivers/ipmi.
config IPMI_KCS_TIMEOUT_MS
int
default 5000
depends on IPMI_KCS
help
The time unit is millisecond for each IPMI KCS transfer.
IPMI spec v2.0 rev 1.1 Sec. 9.15, a five-second timeout or
greater is recommended.

31
src/drivers/ipmi/ipmi_kcs.c
View File

@ -3,7 +3,7 @@
#include <console/console.h> #include <console/console.h>
#include <device/device.h> #include <device/device.h>
#include <arch/io.h> #include <arch/io.h>
#include <delay.h> #include <timer.h>
#include "ipmi_kcs.h" #include "ipmi_kcs.h"
#define IPMI_KCS_STATE(_x) ((_x) >> 6) #define IPMI_KCS_STATE(_x) ((_x) >> 6)
@ -35,27 +35,22 @@ static unsigned char ipmi_kcs_status(int port)
static int wait_ibf_timeout(int port) static int wait_ibf_timeout(int port)
{ {
int timeout = 1000; if (!wait_ms(CONFIG_IPMI_KCS_TIMEOUT_MS, !(ipmi_kcs_status(port) & IPMI_KCS_IBF))) {
do { printk(BIOS_ERR, "wait_ibf timeout!\n");
if (!(ipmi_kcs_status(port) & IPMI_KCS_IBF)) return 1;
return 0; } else {
udelay(100); return 0;
} while (timeout--); }
printk(BIOS_ERR, "wait_ibf timeout!\n");
return timeout;
} }
static int wait_obf_timeout(int port) static int wait_obf_timeout(int port)
{ {
int timeout = 1000; if (!wait_ms(CONFIG_IPMI_KCS_TIMEOUT_MS, (ipmi_kcs_status(port) & IPMI_KCS_OBF))) {
do { printk(BIOS_ERR, "wait_obf timeout!\n");
if ((ipmi_kcs_status(port) & IPMI_KCS_OBF)) return 1;
return 0; } else {
udelay(100); return 0;
} while (timeout--); }
printk(BIOS_ERR, "wait_obf timeout!\n");
return timeout;
} }