GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard/asus/am1i-a: remove unwanted variable 

The variable t32 was originally used to do bitwise operations, but it is
not required anymore. Also, it was assigned twice accidentally, which
introduced a new Coverity Scan defect.

Found-by: Coverity (CID 1385126:    (UNUSED_VALUE))
Change-Id: I77afd5064304a36991f63cf1328e13820144efb6
Signed-off-by: Gergely Kiss <mail.gery@gmail.com>
Reviewed-on: https://review.coreboot.org/23320
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Gergely Kiss 2018-01-18 20:53:06 +01:00 committed by Kyösti Mälkki
parent 82aa8338c7
commit d1eca65908
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/mainboard/asus/am1i-a/romstage.c
View File

@ -116,7 +116,7 @@ static void ite_gpio_conf(pnp_devfn_t dev)
void board_BeforeAgesa(struct sysinfo *cb) void board_BeforeAgesa(struct sysinfo *cb)
{ {
int i; int i;
u32 t32, val; u32 val;
u8 byte; u8 byte;
pci_devfn_t dev; pci_devfn_t dev;
u32 *addr32; u32 *addr32;
@ -145,15 +145,11 @@ void board_BeforeAgesa(struct sysinfo *cb)
/* Configure ClkDrvStr1 settings */ /* Configure ClkDrvStr1 settings */
addr32 = (u32 *)0xfed80e24; addr32 = (u32 *)0xfed80e24;
t32 = *addr32; *addr32 = 0x030800aa;
t32 = 0x030800aa;
*addr32 = t32;
/* Configure MiscClkCntl1 settings */ /* Configure MiscClkCntl1 settings */
addr32 = (u32 *)0xfed80e40; addr32 = (u32 *)0xfed80e40;
t32 = *addr32; *addr32 = 0x000c4050;
t32 = 0x000c4050;
*addr32 = t32;
/* enable SIO LPC decode */ /* enable SIO LPC decode */
dev = PCI_DEV(0, 0x14, 3); dev = PCI_DEV(0, 0x14, 3);