GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/skylake: Shorten SATA mode enum value names 

The Skylake FSP isn't used by coreboot anymore. Therefore, drop the
misleading comment and the "KBLFSP" extension from the names of these
enums.

Also, drop the "MODE" extension to make their names shorter in general,
since it doesn't add any more value.

Built clevo/n130wu with BUILD_TIMELESS=1, coreboot.rom remains
identical.

Change-Id: If37d40e4e1dfd11e9315039acde7cafee0ac60f0
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48377
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Singer 2020-12-06 11:51:10 +01:00 committed by Michael Niewöhner
parent bd7020d68c
commit d60abfcb74
4 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
View File

@ -80,7 +80,7 @@ chip soc/intel/skylake
device pci 16.3 off end # Management Engine KT Redirection
device pci 16.4 off end # Management Engine Interface 3
device pci 17.0 on # SATA
register "SataMode" = "KBLFSP_SATA_MODE_AHCI"
register "SataMode" = "SATA_AHCI"
register "SataSalpSupport" = "0"
# Ports
register "SataPortsEnable[0]" = "1"

2
src/mainboard/kontron/bsl6/devicetree.cb
View File

@ -95,7 +95,7 @@ chip soc/intel/skylake
device pci 16.3 off end # Management Engine KT Redirection
device pci 16.4 off end # Management Engine Interface 3
device pci 17.0 on # SATA
register "SataMode" = "KBLFSP_SATA_MODE_AHCI"
register "SataMode" = "SATA_AHCI"
register "SataSalpSupport" = "1"
register "SataPortsEnable[0]" = "1"
register "SataPortsEnable[1]" = "1"

2
src/mainboard/supermicro/x11-lga1151-series/devicetree.cb
View File

@ -5,7 +5,7 @@ chip soc/intel/skylake
register "SaGv" = "SaGv_Disabled"
# SATA configuration
register "SataMode" = "KBLFSP_SATA_MODE_AHCI"
register "SataMode" = "SATA_AHCI"
register "SataSalpSupport" = "1"
register "SataPortsEnable" = "{ \
[0] = 1, \

7
src/soc/intel/skylake/chip.h
View File

@ -142,11 +142,8 @@ struct soc_intel_skylake_config {
/* SATA related */
enum {
/* Documentation and header files of Skylake FSP disagree on
the values, Kaby Lake FSP (KabylakeFsp0001 on github) uses
these: */
KBLFSP_SATA_MODE_AHCI = 0,
KBLFSP_SATA_MODE_RAID = 1,
SATA_AHCI = 0,
SATA_RAID = 1,
} SataMode;
u8 SataSalpSupport;
u8 SataPortsEnable[8];