GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

coreboot_table: Print GPIO state correctly for lb_gpios 

Looks like there's a typo in the GPIO state table we print as part of
assembling the coreboot tables. Of course, high GPIOs are represented as
1 and low GPIOs as 0. Fix this display bug.

Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/25022
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Julius Werner 2018-03-07 13:06:53 -08:00 committed by Patrick Georgi
parent 85d98d9236
commit dc5d24c837
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/coreboot_table.c
View File

@ -186,10 +186,10 @@ static void lb_gpios(struct lb_header *header)
printk(BIOS_INFO, " low | "); printk(BIOS_INFO, " low | ");
switch (g->value) { switch (g->value) {
case 0: case 0:
printk(BIOS_INFO, " high\n"); printk(BIOS_INFO, " low\n");
break; break;
case 1: case 1:
printk(BIOS_INFO, " low\n"); printk(BIOS_INFO, " high\n");
break; break;
default: default:
printk(BIOS_INFO, "undefined\n"); printk(BIOS_INFO, "undefined\n");