GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/octopus: Set touchpad/screen IRQs to LEVEL vs EDGE 

The GPIOs themselves are configured as level triggered, and the drivers
(both Linux and Windows) work better with LEVEL vs EDGE triggering.

TEST=tested with rest of patch train

Change-Id: I13bc6920a0dfaf769091b1764a7584902d1f85d6
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63213
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2022-03-30 12:30:21 -05:00 committed by Felix Held
parent 34ffa64ba8
commit dc8074560c
12 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/octopus/variants/ampton/overridetree.cb
View File

@ -102,7 +102,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -112,7 +112,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"

4
src/mainboard/google/octopus/variants/bloog/overridetree.cb
View File

@ -118,7 +118,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -128,7 +128,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"

6
src/mainboard/google/octopus/variants/bobba/overridetree.cb
View File

@ -168,7 +168,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -187,7 +187,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"
@ -199,7 +199,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""RAYD0001"" register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen"" register "desc" = ""Raydium Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "1" register "reset_delay_ms" = "1"

2
src/mainboard/google/octopus/variants/casta/overridetree.cb
View File

@ -132,7 +132,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end

6
src/mainboard/google/octopus/variants/dood/overridetree.cb
View File

@ -104,7 +104,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -123,7 +123,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"
@ -135,7 +135,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""RAYD0001"" register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen"" register "desc" = ""Raydium Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "1" register "reset_delay_ms" = "1"

4
src/mainboard/google/octopus/variants/fleex/overridetree.cb
View File

@ -156,7 +156,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -175,7 +175,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"

2
src/mainboard/google/octopus/variants/foob/overridetree.cb
View File

@ -118,7 +118,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end

6
src/mainboard/google/octopus/variants/garg/overridetree.cb
View File

@ -146,7 +146,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -165,7 +165,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"
@ -177,7 +177,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""RAYD0001"" register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen"" register "desc" = ""Raydium Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "1" register "reset_delay_ms" = "1"

2
src/mainboard/google/octopus/variants/lick/overridetree.cb
View File

@ -96,7 +96,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end

4
src/mainboard/google/octopus/variants/meep/overridetree.cb
View File

@ -199,7 +199,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -209,7 +209,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"

4
src/mainboard/google/octopus/variants/phaser/overridetree.cb
View File

@ -131,7 +131,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -175,7 +175,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""RAYD0001"" register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen"" register "desc" = ""Raydium Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "1" register "reset_delay_ms" = "1"

4
src/mainboard/google/octopus/variants/yorp/overridetree.cb
View File

@ -77,7 +77,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad"" register "desc" = ""ELAN Touchpad""
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPIO_135_IRQ)" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPIO_135_IRQ)"
register "wake" = "GPE0_DW3_27" register "wake" = "GPE0_DW3_27"
register "detect" = "1" register "detect" = "1"
device i2c 15 on end device i2c 15 on end
@ -87,7 +87,7 @@ chip soc/intel/apollolake
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0001"" register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen"" register "desc" = ""ELAN Touchscreen""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
register "probed" = "1" register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"