mainboard/amd/tilapia_fam10: Use C89 comments style & remove commented code
Change-Id: I7515288190ca57a321fb8ffe57a1181b638c336a Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/16978 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Elyes HAOUAS
Martin Roth
parent
caccd97d4e
commit
dedccb8556
|
|
@ -88,35 +88,6 @@ void set_pcie_reset()
|
|||
pci_write_config16(sm_dev, 0x7e, word);
|
||||
}
|
||||
|
||||
#if 0 /* TODO: */
|
||||
/********************************************************
|
||||
* tilapia uses SB700 GPIO8 to detect IDE_DMA66.
|
||||
* IDE_DMA66 is routed to GPIO 8. So we read Gpio 8 to
|
||||
* get the cable type, 40 pin or 80 pin?
|
||||
********************************************************/
|
||||
static void get_ide_dma66(void)
|
||||
{
|
||||
u8 byte;
|
||||
/*u32 sm_dev, ide_dev; */
|
||||
device_t sm_dev, ide_dev;
|
||||
|
||||
sm_dev = dev_find_slot(0, PCI_DEVFN(0x14, 0));
|
||||
|
||||
byte = pci_read_config8(sm_dev, 0xA9);
|
||||
byte |= (1 << 4); /* Set Gpio8 as input */
|
||||
pci_write_config8(sm_dev, 0xA9, byte);
|
||||
|
||||
ide_dev = dev_find_slot(0, PCI_DEVFN(0x14, 1));
|
||||
byte = pci_read_config8(ide_dev, 0x56);
|
||||
byte &= ~(7 << 0);
|
||||
if ((1 << 4) & pci_read_config8(sm_dev, 0xAA))
|
||||
byte |= 2 << 0; /* mode 2 */
|
||||
else
|
||||
byte |= 5 << 0; /* mode 5 */
|
||||
pci_write_config8(ide_dev, 0x56, byte);
|
||||
}
|
||||
#endif
|
||||
|
||||
/*
|
||||
* justify the dev3 is exist or not
|
||||
*/
|
||||
|
|
@ -251,18 +222,7 @@ static void set_thermal_config(void)
|
|||
pm_iowrite(0x3c, byte);
|
||||
|
||||
/* THERMTRIP pin */
|
||||
/* byte = pm_ioread(0x68);
|
||||
* byte |= 1 << 3;
|
||||
* pm_iowrite(0x68, byte);
|
||||
*
|
||||
* byte = pm_ioread(0x55);
|
||||
* byte |= 1 << 0;
|
||||
* pm_iowrite(0x55, byte);
|
||||
*
|
||||
* byte = pm_ioread(0x67);
|
||||
* byte &= ~( 1 << 6);
|
||||
* pm_iowrite(0x67, byte);
|
||||
*/
|
||||
|
||||
}
|
||||
|
||||
/*************************************************
|
||||
|
|
@ -274,7 +234,6 @@ static void mainboard_enable(device_t dev)
|
|||
printk(BIOS_INFO, "Mainboard TILAPIA Enable. dev=0x%p\n", dev);
|
||||
|
||||
set_pcie_dereset();
|
||||
/* get_ide_dma66(); */
|
||||
set_thermal_config();
|
||||
set_gpio40_gfx();
|
||||
}
|
||||
|
|
|
|||
|
|
@ -13,8 +13,6 @@
|
|||
* GNU General Public License for more details.
|
||||
*/
|
||||
|
||||
|
||||
|
||||
static void setup_mb_resource_map(void)
|
||||
{
|
||||
static const unsigned int register_values[] = {
|
||||
|
|
@ -45,7 +43,7 @@ static void setup_mb_resource_map(void)
|
|||
* This field defines the upper address bits of a 40 bit address
|
||||
* that define the end of the DRAM region.
|
||||
*/
|
||||
// PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x44), 0x0000f8f8, 0x00000000, // Don't touch it, we need it for CONFIG_CAR_FAM10
|
||||
/* Don't touch it, we need it for CONFIG_CAR_FAM10 */
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x4C), 0x0000f8f8, 0x00000001,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x54), 0x0000f8f8, 0x00000002,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x5C), 0x0000f8f8, 0x00000003,
|
||||
|
|
@ -83,7 +81,7 @@ static void setup_mb_resource_map(void)
|
|||
* This field defines the upper address bits of a 40-bit address
|
||||
* that define the start of the DRAM region.
|
||||
*/
|
||||
// PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x40), 0x0000f8fc, 0x00000000,// don't touch it, we need it for CONFIG_CAR_FAM10
|
||||
/* don't touch it, we need it for CONFIG_CAR_FAM10 */
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x48), 0x0000f8fc, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x50), 0x0000f8fc, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0x58), 0x0000f8fc, 0x00000000,
|
||||
|
|
@ -131,7 +129,6 @@ static void setup_mb_resource_map(void)
|
|||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xA4), 0x00000048, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xAC), 0x00000048, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xB4), 0x00000048, 0x00000000,
|
||||
// PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xBC), 0x00000048, 0x00ffff00,
|
||||
|
||||
/* Memory-Mapped I/O Base i Registers
|
||||
* F1:0x80 i = 0
|
||||
|
|
@ -166,7 +163,6 @@ static void setup_mb_resource_map(void)
|
|||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xA0), 0x000000f0, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xA8), 0x000000f0, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xB0), 0x000000f0, 0x00000000,
|
||||
// PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xB8), 0x000000f0, 0x00fc0003,
|
||||
|
||||
/* PCI I/O Limit i Registers
|
||||
* F1:0xC4 i = 0
|
||||
|
|
@ -193,7 +189,6 @@ static void setup_mb_resource_map(void)
|
|||
* This field defines the end of PCI I/O region n
|
||||
* [31:25] Reserved
|
||||
*/
|
||||
// PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xC4), 0xFE000FC8, 0x01fff000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xCC), 0xFE000FC8, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xD4), 0xFE000FC8, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xDC), 0xFE000FC8, 0x00000000,
|
||||
|
|
@ -223,7 +218,6 @@ static void setup_mb_resource_map(void)
|
|||
* This field defines the start of PCI I/O region n
|
||||
* [31:25] Reserved
|
||||
*/
|
||||
// PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xC0), 0xFE000FCC, 0x00000003,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xC8), 0xFE000FCC, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xD0), 0xFE000FCC, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xD8), 0xFE000FCC, 0x00000000,
|
||||
|
|
@ -264,7 +258,7 @@ static void setup_mb_resource_map(void)
|
|||
* [31:24] Bus Number Limit i
|
||||
* This field defines the highest bus number in configuration regin i
|
||||
*/
|
||||
// PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xE0), 0x0000FC88, 0x06000003, // AMD 8111 on link0 of CPU 0
|
||||
/* AMD 8111 on link0 of CPU 0 */
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xE4), 0x0000FC88, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xE8), 0x0000FC88, 0x00000000,
|
||||
PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xEC), 0x0000FC88, 0x00000000,
|
||||
|
|
|
|||
|
|
@ -13,11 +13,9 @@
|
|||
* GNU General Public License for more details.
|
||||
*/
|
||||
|
||||
//#define SYSTEM_TYPE 0 /* SERVER */
|
||||
#define SYSTEM_TYPE 1 /* DESKTOP */
|
||||
//#define SYSTEM_TYPE 2 /* MOBILE */
|
||||
|
||||
//used by incoherent_ht
|
||||
/* used by incoherent_ht */
|
||||
#define FAM10_SCAN_PCI_BUS 0
|
||||
#define FAM10_ALLOCATE_IO_RANGE 0
|
||||
|
||||
|
|
@ -102,12 +100,10 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
|
|||
|
||||
console_init();
|
||||
|
||||
// dump_mem(CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE-0x200, CONFIG_DCACHE_RAM_BASE+CONFIG_DCACHE_RAM_SIZE);
|
||||
|
||||
/* Halt if there was a built in self test failure */
|
||||
report_bist_failure(bist);
|
||||
|
||||
// Load MPB
|
||||
/* Load MPB */
|
||||
val = cpuid_eax(1);
|
||||
printk(BIOS_DEBUG, "BSP Family_Model: %08x\n", val);
|
||||
printk(BIOS_DEBUG, "*sysinfo range: [%p,%p]\n",sysinfo,sysinfo+1);
|
||||
|
|
@ -166,10 +162,10 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
|
|||
|
||||
post_code(0x39);
|
||||
|
||||
if (!warm_reset_detect(0)) { // BSP is node 0
|
||||
if (!warm_reset_detect(0)) { /* BSP is node 0 */
|
||||
init_fidvid_bsp(bsp_apicid, sysinfo->nodes);
|
||||
} else {
|
||||
init_fidvid_stage2(bsp_apicid, 0); // BSP is node 0
|
||||
init_fidvid_stage2(bsp_apicid, 0); /* BSP is node 0 */
|
||||
}
|
||||
|
||||
post_code(0x3A);
|
||||
|
|
@ -196,8 +192,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
|
|||
|
||||
post_code(0x40);
|
||||
|
||||
// die("Die Before MCT init.");
|
||||
|
||||
timestamp_add_now(TS_BEFORE_INITRAM);
|
||||
printk(BIOS_DEBUG, "raminit_amdmct()\n");
|
||||
raminit_amdmct(sysinfo);
|
||||
|
|
@ -208,21 +202,12 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
|
|||
|
||||
amdmct_cbmem_store_info(sysinfo);
|
||||
|
||||
/*
|
||||
dump_pci_device_range(PCI_DEV(0, 0x18, 0), 0, 0x200);
|
||||
dump_pci_device_range(PCI_DEV(0, 0x18, 1), 0, 0x200);
|
||||
dump_pci_device_range(PCI_DEV(0, 0x18, 2), 0, 0x200);
|
||||
dump_pci_device_range(PCI_DEV(0, 0x18, 3), 0, 0x200);
|
||||
*/
|
||||
|
||||
// die("After MCT init before CAR disabled.");
|
||||
|
||||
rs780_before_pci_init();
|
||||
sb7xx_51xx_before_pci_init();
|
||||
|
||||
post_code(0x42);
|
||||
post_cache_as_ram(); // BSP switch stack to ram, copy then execute LB.
|
||||
post_code(0x43); // Should never see this post code.
|
||||
post_cache_as_ram(); /* BSP switch stack to ram, copy then execute LB. */
|
||||
post_code(0x43); /* Should never see this post code. */
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
|||
Loading…
Reference in New Issue