GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Move if EC_GOOGLE_CHROMEEC to i2c_tunnel/Kconfig 

This change moves `if EC_GOOGLE_CHROMEEC` from chromeec/Kconfig to
chromeec/i2c_tunnel/Kconfig. This is done to make it clear that the
Kconfig file in i2c_tunnel is sourced unconditionally, but the configs
in i2c_tunnel/Kconfig are conditionally defined based on the
evaluation of if condition.

This change addressed the feedback received on
https://review.coreboot.org/c/coreboot/+/40515/11/src/ec/google/chromeec/Kconfig#200.

Change-Id: I66cd91d6b1813ff6d0fb7be719e2da65ac6ac23b
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43040
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2020-07-02 16:37:17 -07:00
parent ee68b88bab
commit dfd7e9d560
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ec/google/chromeec/Kconfig
View File

@ -197,8 +197,4 @@ config EC_GOOGLE_CHROMEEC_SWITCHES
Enable support for Chrome OS mode switches provided by the Chrome OS Enable support for Chrome OS mode switches provided by the Chrome OS
EC. EC.
if EC_GOOGLE_CHROMEEC
source "src/ec/google/chromeec/*/Kconfig" source "src/ec/google/chromeec/*/Kconfig"
endif

4
src/ec/google/chromeec/i2c_tunnel/Kconfig
View File

@ -1,6 +1,10 @@
if EC_GOOGLE_CHROMEEC
config EC_GOOGLE_CHROMEEC_I2C_TUNNEL config EC_GOOGLE_CHROMEEC_I2C_TUNNEL
bool bool
depends on HAVE_ACPI_TABLES depends on HAVE_ACPI_TABLES
help help
This enables the Cros EC I2C tunnel driver that is required to fill the This enables the Cros EC I2C tunnel driver that is required to fill the
SSDT nodes for the I2C tunnel used by the mainboard. SSDT nodes for the I2C tunnel used by the mainboard.
endif