GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/mediatek: Add error handling for dptx_get_edid() 

Skip eDP initialization when we failed to get EDID. This prevents the
PLL assertion in dp_intf_config() if the display could not be
initialized properly.

BUG=b:233720142
TEST=boot to depthcharge on MT8188 EVB.

Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07
Signed-off-by: Liju-Clr Chen <liju-clr.chen@mediatek.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69858
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Liju-Clr Chen 2022-11-21 18:36:36 +08:00 committed by Felix Held
parent 977673894f
commit e1ee23f29d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/soc/mediatek/common/dp/dptx.c
View File

@ -1111,7 +1111,10 @@ int mtk_edp_init(struct edid *edid)
dptx_check_sinkcap(&mtk_edp); dptx_check_sinkcap(&mtk_edp);
dptx_get_edid(&mtk_edp, edid); if (dptx_get_edid(&mtk_edp, edid) != 0) {
printk(BIOS_ERR, "Failed to get EDID\n");
return -1;
}
dptx_set_trainingstart(&mtk_edp); dptx_set_trainingstart(&mtk_edp);
dp_intf_config(edid); dp_intf_config(edid);