amdfam10: Convert to `board_reset()`

And here comes the mess...

This just renames do_hard_reset() to do_board_reset() and keeps current
behaviour. As these are never called from chipset or board code but only
from common code, it's likely that their implementations are untested
and not what we actually want. Also note, that sometimes implementations
for rom- and ramstage differ considerably.

Change-Id: Icdf55ed1a0e0294933f61749a37da2ced01da61c
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/29058
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber 2018-10-07 12:12:27 +02:00 committed by Patrick Georgi
parent f4181052af
commit e20dd19dde
21 changed files with 12 additions and 21 deletions

View File

@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_ROMSTAGE_CONSOLE_SPINLOCK
select HAVE_ROMSTAGE_NVRAM_CBFS_SPINLOCK
select HAVE_ROMSTAGE_MICROCODE_CBFS_SPINLOCK
select HAVE_HARD_RESET
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
select HAVE_PIRQ_TABLE

View File

@ -9,7 +9,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SOUTHBRIDGE_NVIDIA_CK804
select SUPERIO_WINBOND_W83627THG
select PARALLEL_CPU_INIT
select HAVE_HARD_RESET
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
select HAVE_PIRQ_TABLE

View File

@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_ROMSTAGE_CONSOLE_SPINLOCK
select HAVE_ROMSTAGE_NVRAM_CBFS_SPINLOCK
select HAVE_ROMSTAGE_MICROCODE_CBFS_SPINLOCK
select HAVE_HARD_RESET
select HAVE_OPTION_TABLE
select HAVE_CMOS_DEFAULT
select HAVE_PIRQ_TABLE

View File

@ -16,7 +16,6 @@
config SOUTHBRIDGE_AMD_AMD8111
bool
select IOAPIC
select HAVE_HARD_RESET
config BOOTBLOCK_SOUTHBRIDGE_INIT
string

View File

@ -52,7 +52,7 @@ static void enable_cf9(void)
enable_cf9_x(sbbusn, sbdn);
}
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();
/* reset */

View File

@ -37,7 +37,7 @@ static pci_devfn_t pci_io_locate_device_on_bus(unsigned pci_id, unsigned bus)
#include "../../../northbridge/amd/amdk8/reset_test.c"
void do_hard_reset(void)
void do_board_reset(void)
{
pci_devfn_t dev;
unsigned bus;

View File

@ -22,7 +22,6 @@ config SOUTHBRIDGE_SPECIFIC_OPTIONS # dummy
def_bool y
select IOAPIC
select HAVE_USBDEBUG_OPTIONS
select HAVE_HARD_RESET
select SMBUS_HAS_AUX_CHANNELS
config SOUTHBRIDGE_AMD_SB700_33MHZ_SPI

View File

@ -44,7 +44,7 @@ static void set_bios_reset(void)
}
}
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();

View File

@ -17,7 +17,6 @@ config SOUTHBRIDGE_AMD_SB800
bool
select IOAPIC
select HAVE_USBDEBUG_OPTIONS
select HAVE_HARD_RESET
if SOUTHBRIDGE_AMD_SB800

View File

@ -218,7 +218,7 @@ static void enable_fid_change_on_sb(u32 sbbusn, u32 sbdn)
pmio_write(0x81, byte);
}
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();

View File

@ -21,7 +21,7 @@
#include <northbridge/amd/amdk8/reset_test.c>
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();
/* Try rebooting through port 0xcf9 */

View File

@ -1,6 +1,5 @@
config SOUTHBRIDGE_BROADCOM_BCM5785
bool
select HAVE_HARD_RESET
config BOOTBLOCK_SOUTHBRIDGE_INIT
string

View File

@ -103,7 +103,7 @@ void ldtstop_sb(void)
}
void do_hard_reset(void)
void do_board_reset(void)
{
bcm5785_enable_wdt_port_cf9();

View File

@ -21,7 +21,7 @@
#include "../../../northbridge/amd/amdk8/reset_test.c"
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();
/* Try rebooting through port 0xcf9 */

View File

@ -1,6 +1,5 @@
config SOUTHBRIDGE_NVIDIA_CK804
bool
select HAVE_HARD_RESET
select HAVE_USBDEBUG
select IOAPIC

View File

@ -310,7 +310,7 @@ static int ck804_early_setup_x(void)
return set_ht_link_ck804(4);
}
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();

View File

@ -355,7 +355,7 @@ static int ck804_early_setup_x(void)
return set_ht_link_ck804(4);
}
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();

View File

@ -21,7 +21,7 @@
#include "../../../northbridge/amd/amdk8/reset_test.c"
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();
/* Try rebooting through port 0xcf9. */

View File

@ -2,7 +2,6 @@ config SOUTHBRIDGE_NVIDIA_MCP55
bool
select HAVE_USBDEBUG
select IOAPIC
select HAVE_HARD_RESET
if SOUTHBRIDGE_NVIDIA_MCP55

View File

@ -29,7 +29,7 @@ void do_soft_reset(void)
outb(0x06, 0x0cf9);
}
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();

View File

@ -24,7 +24,7 @@
#include "../../../northbridge/amd/amdk8/reset_test.c"
void do_hard_reset(void)
void do_board_reset(void)
{
set_bios_reset();
/* Try rebooting through port 0xcf9 */