GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/gimble{4es}: Decrease touchscreen T3 timing to 200ms 

We set T3 as 300ms to meet Elan's spec, but the resume/suspend times
are greater than 500ms, which is the spec for Chromebooks.
The actual kernel timing has been measured, and given the ACPI delay
after deasserting reset in addition to the delay until the kernel
driver accesses the device, delaying only 200ms in the ACPI method is
also sufficient to meet the 300ms requirement.

BUG=b:210772498
BRANCH=none
TEST=build and test touchscreen function on DUT.
TEST=suspend, wake DUT and check touchscreen function.

Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: I4bb4eda09686cb59b6e19c741aa2b78d84332d2a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60270
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
This commit is contained in:
Scott Chao 2021-12-21 14:18:31 +08:00 committed by Felix Held
parent 25387927c0
commit e24b006ee4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/brya/variants/gimble/overridetree.cb
View File

@ -198,7 +198,7 @@ chip soc/intel/alderlake
register "generic.probed" = "1" register "generic.probed" = "1"
register "generic.reset_gpio" = register "generic.reset_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)"
register "generic.reset_delay_ms" = "300" register "generic.reset_delay_ms" = "200"
register "generic.reset_off_delay_ms" = "1" register "generic.reset_off_delay_ms" = "1"
register "generic.enable_gpio" = register "generic.enable_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"

2
src/mainboard/google/brya/variants/gimble4es/overridetree.cb
View File

@ -161,7 +161,7 @@ chip soc/intel/alderlake
register "generic.probed" = "1" register "generic.probed" = "1"
register "generic.reset_gpio" = register "generic.reset_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)"
register "generic.reset_delay_ms" = "300" register "generic.reset_delay_ms" = "200"
register "generic.reset_off_delay_ms" = "1" register "generic.reset_off_delay_ms" = "1"
register "generic.enable_gpio" = register "generic.enable_gpio" =
"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"