GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/facebook/fbg1701: Remove ONBOARD_SAMSUNG_MEM 

CONFIG_ONBOARD_SAMSUMG_MEM was used to force Samsung memory.

CPLD returns different values for every board revision. Use this value
to determine the memory type.

BUG = N/A
TEST = Boot Facebook FBG1701 Rev 1.0 - 1.4

Change-Id: I21b5ddc430410a1e8b3e9012d0c07d278880ff47
Signed-off-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59754
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Frans Hendriks 2021-12-02 08:08:17 +01:00 committed by Felix Held
parent 26e384bf34
commit e6ffdb47cd
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/mainboard/facebook/fbg1701/romstage.c
View File

@ -18,13 +18,24 @@
void mainboard_memory_init_params(struct romstage_params *params, void mainboard_memory_init_params(struct romstage_params *params,
MEMORY_INIT_UPD *memory_params) MEMORY_INIT_UPD *memory_params)
{ {
u8 spd_index = 0; u8 spd_index;
if (!CONFIG(ONBOARD_SAMSUNG_MEM)) { switch (cpld_read_pcb_version()) {
if (cpld_read_pcb_version() <= 7) case 0: /* intentional fallthrough */
spd_index = 1; case 1: /* intentional fallthrough */
else case 2: /* intentional fallthrough */
spd_index = 2; case 3: /* intentional fallthrough */
case 4: /* intentional fallthrough */
case 5:
spd_index = 0;
break;
case 6: /* intentional fallthrough */
case 7:
spd_index = 1;
break;
default:
spd_index = 2;
break;
} }
memory_params->PcdMemoryTypeEnable = MEM_DDR3; memory_params->PcdMemoryTypeEnable = MEM_DDR3;