GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy: Power on PMIC before accessing its opregion 

The PMIC opregion is used to change the direction of two GPIOs for I²C
daisy chain operation. Do this after the PMIC is powered on, not before.

BUG=chromium:959232

Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Jacopo Mondi <jacopo@jmondi.org>
Change-Id: I923987ef21a971df9e32ca03f2da4dccdac07843
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36722
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Sakari Ailus 2019-11-01 12:12:41 +02:00 committed by Patrick Georgi
parent 2d54fc9581
commit ecfb4b81ae
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
View File

@ -458,16 +458,16 @@ Scope (\_SB.PCI0.I2C2)
/* TODO: Read Voltage and Sleep values from Sensor Obj */ /* TODO: Read Voltage and Sleep values from Sensor Obj */
If (LEqual (AVBL, 1)) { If (LEqual (AVBL, 1)) {
If (LEqual (STA, 0)) { If (LEqual (STA, 0)) {
/* Enable VSIO regulator +
daisy chain */
DOVD(1)
If (LEqual (C0GP, 0)) { If (LEqual (C0GP, 0)) {
\_SB.PCI0.I2C2.PMIC.CGP1() \_SB.PCI0.I2C2.PMIC.CGP1()
\_SB.PCI0.I2C2.PMIC.CGP2() \_SB.PCI0.I2C2.PMIC.CGP2()
C0GP = 1 C0GP = 1
} }
/* Enable VSIO regulator +
daisy chain */
DOVD(1)
VACT = 1 VACT = 1
if (LNotEqual (ACVA, 109)) { if (LNotEqual (ACVA, 109)) {
/* Set ANA at 2.8152V */ /* Set ANA at 2.8152V */