GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard/ocp/monolake: Hide IIO root ports before memory init 

It turned on some SKUs FSP hangs in Notify stage if IIO root ports are
disabled after MemoryInit. To address that hide IIO root ports earlier
in romstage.

TEST=the patch was ran on affected HW and success was reported

Change-Id: I6a2a405f729df14f46bcf34a24e66e8ba9415f9d
Signed-off-by: Andrey Petrov <anpetrov@fb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35968
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
This commit is contained in:
Andrey Petrov 2019-10-11 11:31:08 -07:00 committed by Patrick Georgi
parent 89f5967647
commit ee0b7ad683
5 changed files with 52 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Documentation/soc/intel/fsp/index.md
View File

@ -21,6 +21,12 @@ those are fixed. If possible a workaround is described here as well.
* Workaround: Don't disable this PCI device
* Issue on public tracker: [Issue 13]
* FSP Notify(EnumInitPhaseAfterPciEnumeration) hangs if 00:02.03/00:02.03 are hidden
* Release MR2
* Seems to get stuck on some SKUs only if hidden after MemoryInit
* Workaround: Hide before MemoryInit
* Issue on public tracker: [Issue 35]
### KabylakeFsp
* MfgId and ModulePartNum in the DIMM_INFO struct are empty
* Release 3.7.1
@ -59,4 +65,5 @@ those are fixed. If possible a workaround is described here as well.
[Issue 13]: https://github.com/IntelFsp/FSP/issues/13
[Issue 15]: https://github.com/IntelFsp/FSP/issues/15
[Issue 22]: https://github.com/IntelFsp/FSP/issues/22
[Issue 35]: https://github.com/IntelFsp/FSP/issues/35

3
src/soc/intel/fsp_broadwell_de/include/soc/ubox.h
View File

@ -40,6 +40,5 @@
#define UBOX_DEVHIDE0 0xb0
void iio_hide(const uint8_t devno, const uint8_t funcno);
void iio_hide(DEVTREE_CONST struct device *dev);
#endif

36
src/soc/intel/fsp_broadwell_de/romstage/romstage.c
View File

@ -94,6 +94,37 @@ static void enable_integrated_uart(uint8_t port)
pci_mmio_write_config32(ubox_dev, UBOX_UART_ENABLE, ubox_uart_en);
}
static void early_iio_hide(void)
{
DEVTREE_CONST struct device *dev;
const pci_devfn_t iio_rootport[] = {
PCI_DEVFN(PCIE_IIO_PORT_1_DEV, PCIE_IIO_PORT_1A_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_1_DEV, PCIE_IIO_PORT_1B_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_2_DEV, PCIE_IIO_PORT_2A_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_2_DEV, PCIE_IIO_PORT_2B_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_2_DEV, PCIE_IIO_PORT_2C_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_2_DEV, PCIE_IIO_PORT_2D_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_3_DEV, PCIE_IIO_PORT_3A_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_3_DEV, PCIE_IIO_PORT_3B_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_3_DEV, PCIE_IIO_PORT_3C_FUNC),
PCI_DEVFN(PCIE_IIO_PORT_3_DEV, PCIE_IIO_PORT_3D_FUNC),
};
/* Walk through IIO root ports and hide if it is disabled in devtree */
for (int i = 0; i < ARRAY_SIZE(iio_rootport); i++) {
dev = pcidev_path_on_bus(BUS0, iio_rootport[i]);
if (dev && !dev->enabled) {
printk(BIOS_DEBUG, "Hiding IIO root port: %d:%d.%d\n",
BUS0,
PCI_SLOT(iio_rootport[i]),
PCI_FUNC(iio_rootport[i]));
iio_hide(dev);
}
}
}
/* Entry from cache-as-ram.inc. */
void *asmlinkage main(FSP_INFO_HEADER *fsp_info_header)
{
@ -121,14 +152,15 @@ void *asmlinkage main(FSP_INFO_HEADER *fsp_info_header)
init_rtc();
setup_gpio_io_address();
/* Hide before MemoryInit since hiding later seems to break FSP */
early_iio_hide();
timestamp_add_now(TS_BEFORE_INITRAM);
post_code(0x48);
/*
* Call early init to initialize memory and chipset. This function returns
* to the romstage_main_continue function with a pointer to the HOB
* structure.
*/
post_code(0x48);
printk(BIOS_DEBUG, "Starting the Intel FSP (early_init)\n");
fsp_early_init(fsp_info_header);
die_with_post_code(POST_INVALID_VENDOR_BINARY,

23
src/soc/intel/fsp_broadwell_de/southcluster.c
View File

@ -257,24 +257,11 @@ void southcluster_enable_dev(struct device *dev)
const int slot = PCI_SLOT(dev->path.pci.devfn);
const int func = PCI_FUNC(dev->path.pci.devfn);
switch (slot) {
case PCIE_IIO_PORT_0_DEV:
die("should not hide PCH link");
case PCIE_IIO_PORT_1_DEV: /* fallthrough */
case PCIE_IIO_PORT_2_DEV: /* fallthrough */
case PCIE_IIO_PORT_3_DEV: /* fallthrough */
printk(BIOS_DEBUG, "%s: Disabling IOU bridge %02x.%01x\n", dev_path(dev), slot,
func);
iio_hide(slot, func);
break;
default:
printk(BIOS_DEBUG, "%s: Disabling device: %02x.%01x\n", dev_path(dev), slot,
func);
/* Ensure memory, io, and bus master are all disabled */
reg32 = pci_read_config32(dev, PCI_COMMAND);
reg32 &= ~(PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
pci_write_config32(dev, PCI_COMMAND, reg32);
}
printk(BIOS_DEBUG, "%s: Disabling device: %02x.%01x\n", dev_path(dev), slot, func);
/* Ensure memory, io, and bus master are all disabled */
reg32 = pci_read_config32(dev, PCI_COMMAND);
reg32 &= ~(PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
pci_write_config32(dev, PCI_COMMAND, reg32);
}
#if CONFIG(HAVE_ACPI_TABLES)

7
src/soc/intel/fsp_broadwell_de/ubox.c
View File

@ -18,10 +18,13 @@
#include <stdint.h>
#include <soc/ubox.h>
void iio_hide(const uint8_t devno, const uint8_t funcno)
void iio_hide(DEVTREE_CONST struct device *dev)
{
pci_devfn_t ubox_dev;
uint8_t slot, func;
slot = PCI_SLOT(dev->path.pci.devfn);
func = PCI_FUNC(dev->path.pci.devfn);
ubox_dev = PCI_DEV(get_busno1(), UBOX_DEV, UBOX_FUNC);
pci_or_config32(ubox_dev, UBOX_DEVHIDE0 + funcno * 4, 1 << devno);
pci_or_config32(ubox_dev, UBOX_DEVHIDE0 + func * 4, 1 << slot);
}