GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nortbridge/sandybridge/mrccache: parse the return code of flash->write 

Change-Id: I2738da99e4651598faeaa228fba447d0872e9ded
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Reviewed-on: https://review.coreboot.org/13999
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Alexander Couzens 2016-03-09 04:02:42 +01:00 committed by Martin Roth
parent 10d6fceaa0
commit f0ab23cb03
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/northbridge/intel/sandybridge/mrccache.c
View File

@ -160,6 +160,7 @@ static void update_mrc_cache(void *unused)
struct mrc_data_container *current = cbmem_find(CBMEM_ID_MRCDATA); struct mrc_data_container *current = cbmem_find(CBMEM_ID_MRCDATA);
struct mrc_data_container *cache, *cache_base; struct mrc_data_container *cache, *cache_base;
u32 cache_size; u32 cache_size;
int ret;
if (!current) { if (!current) {
printk(BIOS_ERR, "No MRC cache in cbmem. Can't update flash.\n"); printk(BIOS_ERR, "No MRC cache in cbmem. Can't update flash.\n");
@ -220,8 +221,14 @@ static void update_mrc_cache(void *unused)
// 4. write mrc data with flash->write() // 4. write mrc data with flash->write()
printk(BIOS_DEBUG, "Finally: write MRC cache update to flash at %p\n", printk(BIOS_DEBUG, "Finally: write MRC cache update to flash at %p\n",
cache); cache);
flash->write(flash, to_flash_offset(flash, cache), ret = flash->write(flash, to_flash_offset(flash, cache),
current->mrc_data_size + sizeof(*current), current); current->mrc_data_size + sizeof(*current), current);
if (ret)
printk(BIOS_WARNING, "Writing the MRC cache failed with ret %d\n",
ret);
else
printk(BIOS_DEBUG, "Successfully wrote MRC cache\n");
} }
BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, update_mrc_cache, NULL); BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, update_mrc_cache, NULL);