GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/data_fabric: add warning about broadcast reads 

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: If1b65ae3dd2b5c8fe7bc29a267d108e4d3a3e567
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50883
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2021-02-18 20:34:21 +01:00
parent 746f438ada
commit f1eaa67221
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/block/data_fabric/data_fabric_helper.c
View File

@ -23,6 +23,8 @@ static void data_fabric_set_indirect_address(uint8_t func, uint16_t reg, uint8_t
uint32_t data_fabric_read32(uint8_t function, uint16_t reg, uint8_t instance_id) uint32_t data_fabric_read32(uint8_t function, uint16_t reg, uint8_t instance_id)
{ {
/* Broadcast reads might return unexpected results when a register has different
contents in the different instances. */
if (instance_id == BROADCAST_FABRIC_ID) if (instance_id == BROADCAST_FABRIC_ID)
return data_fabric_broadcast_read32(function, reg); return data_fabric_broadcast_read32(function, reg);