GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/azalia_device.c: Clarify comment 

The `4` here doesn't have to do with the size of u32. Instead, it is
because the verb header contains the number of jacks, which is the
number of four-verb groups.

Change-Id: I3956ce5ec2a7abc29982504cf75b262a1c098af5
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48352
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Angel Pons 2020-12-05 18:32:05 +01:00 committed by Hung-Te Lin
parent d3f7028993
commit f23c6a8ff5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/device/azalia_device.c
View File

@ -115,7 +115,8 @@ u32 azalia_find_verb(const u32 *verb_table, u32 verb_table_bytes, u32 viddid, co
int idx = 0; int idx = 0;
while (idx < (verb_table_bytes / sizeof(u32))) { while (idx < (verb_table_bytes / sizeof(u32))) {
u32 verb_size = 4 * verb_table[idx + 2]; // in u32 /* Header contains the number of jacks, aka groups of 4 dwords */
u32 verb_size = 4 * verb_table[idx + 2];
if (verb_table[idx] != viddid) { if (verb_table[idx] != viddid) {
idx += verb_size + 3; // skip verb + header idx += verb_size + 3; // skip verb + header
continue; continue;