GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only BSP CPU writes CMOS in bootblock code 

CMOS accesses are not safe for multi-processor and only the BSP CPU
should count reboots and test CMOS sanity.

A questionable single byte CMOS read access from AP CPUs remains.
AP CPUs should always select the same romstage prefix as BSP CPU.

Change-Id: I29118e33c07c0080c94abb90f703e38312c72432
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/446
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Kyösti Mälkki 2011-12-05 20:17:17 +02:00 committed by Patrick Georgi
parent f42fdabe65
commit f28dbe0c5d
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/arch/x86/init/bootblock_normal.c
View File

@ -3,18 +3,28 @@
static void main(unsigned long bist)
{
unsigned long entry;
int boot_mode;
if (boot_cpu()) {
bootblock_northbridge_init();
bootblock_southbridge_init();
bootblock_cpu_init();
}
#if CONFIG_USE_OPTION_TABLE
sanitize_cmos();
sanitize_cmos();
#endif
boot_mode = do_normal_boot();
} else {
unsigned long entry;
if (do_normal_boot())
/* Questionable single byte read from CMOS.
* Do not add any other CMOS access in the
* bootblock for AP CPUs.
*/
boot_mode = last_boot_normal();
}
if (boot_mode)
entry = findstage("normal/romstage");
else
entry = findstage("fallback/romstage");

4
src/arch/x86/init/bootblock_simple.c
View File

@ -6,11 +6,11 @@ static void main(unsigned long bist)
bootblock_northbridge_init();
bootblock_southbridge_init();
bootblock_cpu_init();
}
#if CONFIG_USE_OPTION_TABLE
sanitize_cmos();
sanitize_cmos();
#endif
}
const char* target1 = "fallback/romstage";
unsigned long entry;