GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hexdump: fix compiler warning 

Fixed "warning: format not a string literal and no format arguments"

Change-Id: If752a37f268c90f782c6e831e5477ea804e48026
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Reviewed-on: http://review.coreboot.org/878
Tested-by: build bot (Jenkins)
Reviewed-by: Bernhard Urban <lewurm@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Vikram Narayanan 2012-04-07 16:28:26 +05:30 committed by Stefan Reinauer
parent e875328c79
commit f42c377fed
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
util/nvramtool/hexdump.c
View File

@ -83,10 +83,10 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start,
bytes_left >= format->bytes_per_line; bytes_left >= format->bytes_per_line;
bytes_left -= format->bytes_per_line) { bytes_left -= format->bytes_per_line) {
/* print start address for current line */ /* print start address for current line */
fprintf(outfile, format->indent); fprintf(outfile, "%s", format->indent);
addrprint(outfile, addrprint_start + index, addrprint(outfile, addrprint_start + index,
format->addrprint_width); format->addrprint_width);
fprintf(outfile, format->sep1); fprintf(outfile, "%s", format->sep1);
/* display the bytes in hex */ /* display the bytes in hex */
for (i = 0;;) { for (i = 0;;) {
@ -95,11 +95,11 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start,
if (++i >= format->bytes_per_line) if (++i >= format->bytes_per_line)
break; break;
fprintf(outfile, format->sep2); fprintf(outfile, "%s", format->sep2);
} }
index -= format->bytes_per_line; index -= format->bytes_per_line;
fprintf(outfile, format->sep3); fprintf(outfile, "%s", format->sep3);
/* display the bytes as characters */ /* display the bytes as characters */
for (i = 0; i < format->bytes_per_line; i++, index++) for (i = 0; i < format->bytes_per_line; i++, index++)
@ -112,14 +112,14 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start,
return; return;
/* print start address for last line */ /* print start address for last line */
fprintf(outfile, format->indent); fprintf(outfile, "%s", format->indent);
addrprint(outfile, addrprint_start + index, format->addrprint_width); addrprint(outfile, addrprint_start + index, format->addrprint_width);
fprintf(outfile, format->sep1); fprintf(outfile, "%s", format->sep1);
/* display bytes for last line in hex */ /* display bytes for last line in hex */
for (i = 0; i < bytes_left; i++) { for (i = 0; i < bytes_left; i++) {
fprintf(outfile, "%02x", p[index++]); fprintf(outfile, "%02x", p[index++]);
fprintf(outfile, format->sep2); fprintf(outfile, "%s", format->sep2);
} }
index -= bytes_left; index -= bytes_left;
@ -131,10 +131,10 @@ void hexdump(const void *mem, int bytes, uint64_t addrprint_start,
if (++i >= format->bytes_per_line) if (++i >= format->bytes_per_line)
break; break;
fprintf(outfile, format->sep2); fprintf(outfile, "%s", format->sep2);
} }
fprintf(outfile, format->sep3); fprintf(outfile, "%s", format->sep3);
/* display bytes for last line as characters */ /* display bytes for last line as characters */
for (i = 0; i < bytes_left; i++) for (i = 0; i < bytes_left; i++)