GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/ite/it8623e: initialize the PWM fan controller 

Copies the common/env_ctrl support code from the it8728f driver.

Tested on an ASUS AM1I-A using Linux 4.16.7-gentoo as payload,
and booting userspace without a kexec call.

Prior to this change, an error was given during boot:

it87 it87.656: Detected broken BIOS defaults, disabling PWM interface

After this change, the message is gone, and PWM fan control works
through the /sys/class/hwmon interface.

Change-Id: Id97c4ec19562e7c78308c5afe6ff7c938922c9e7
Signed-off-by: Kevin Cody-Little <kcodyjr@gmail.com>
Reviewed-on: https://review.coreboot.org/26224
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kevin Cody-Little 2018-05-10 21:33:03 -04:00 committed by Nico Huber
parent e100fe4a59
commit f5f552afcd
3 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/superio/ite/it8623e/Kconfig
View File

@ -4,6 +4,7 @@
## Copyright (C) 2009 Ronald G. Minnich ## Copyright (C) 2009 Ronald G. Minnich
## Copyright (C) 2014 Edward O'Callaghan <eocallaghan@alterapraxis.com> ## Copyright (C) 2014 Edward O'Callaghan <eocallaghan@alterapraxis.com>
## Copyright (C) 2017 Gergely Kiss <mail.gery@gmail.com> ## Copyright (C) 2017 Gergely Kiss <mail.gery@gmail.com>
## Copyright (C) 2018 Kevin Cody-Little <kcodyjr@gmail.com>
## ##
## This program is free software; you can redistribute it and/or modify ## This program is free software; you can redistribute it and/or modify
## it under the terms of the GNU General Public License as published by ## it under the terms of the GNU General Public License as published by
@ -18,3 +19,7 @@
config SUPERIO_ITE_IT8623E config SUPERIO_ITE_IT8623E
bool bool
select SUPERIO_ITE_COMMON_ROMSTAGE select SUPERIO_ITE_COMMON_ROMSTAGE
select SUPERIO_ITE_ENV_CTRL
select SUPERIO_ITE_ENV_CTRL_PWM_FREQ2
select SUPERIO_ITE_ENV_CTRL_FAN16_CONFIG
select SUPERIO_ITE_ENV_CTRL_8BIT_PWM

26
src/superio/ite/it8623e/chip.h Normal file
View File

@ -0,0 +1,26 @@
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2014 Edward O'Callaghan <eocallaghan@alterapraxis.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#ifndef SUPERIO_ITE_IT8623E_CHIP_H
#define SUPERIO_ITE_IT8623E_CHIP_H
#include <superio/ite/common/env_ctrl_chip.h>
struct superio_ite_it8623e_config {
struct ite_ec_config ec;
};
#endif /* SUPERIO_ITE_IT8623E_CHIP_H */

8
src/superio/ite/it8623e/superio.c
View File

@ -22,17 +22,25 @@
#include <arch/io.h> #include <arch/io.h>
#include <stdlib.h> #include <stdlib.h>
#include <superio/conf_mode.h> #include <superio/conf_mode.h>
#include <superio/ite/common/env_ctrl.h>
#include "chip.h"
#include "it8623e.h" #include "it8623e.h"
static void it8623e_init(struct device *dev) static void it8623e_init(struct device *dev)
{ {
const struct superio_ite_it8623e_config *conf = dev->chip_info;
const struct resource *res;
if (!dev->enabled) if (!dev->enabled)
return; return;
switch (dev->path.pnp.device) { switch (dev->path.pnp.device) {
case IT8623E_EC: case IT8623E_EC:
res = find_resource(dev, PNP_IDX_IO0);
if (!conf || !res)
break;
ite_ec_init(res->base, &conf->ec);
break; break;
case IT8623E_KBCK: case IT8623E_KBCK:
pc_keyboard_init(NO_AUX_DEVICE); pc_keyboard_init(NO_AUX_DEVICE);