GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/nissa/var/craask: Modify clkreq to clksrc mapping 

NVMe PCIe 9-12 using clk_src1 and clk_req2 mapping to hardware design,
Due to inconsistency between PMC firmware and FSP, we need to set
clk_src to clk_req number, not same as hardware mapping in coreboot.
Then swap correct setting to clk_src=1,clk_req=2 in mFIT.

BUG=b:265720813
TEST=build firmware and veirfy suspend function on DUT.

Cq-Depend: chrome-internal:5351299
Change-Id: Ia057dfa98cb9293d9e212edb4e4ac198e94e8985
Signed-off-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72051
Reviewed-by: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Reviewed-by: Kangheui Won <khwon@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Ren Kuo 2023-01-18 16:23:54 +08:00 committed by Martin L Roth
parent f4ac5ea179
commit f700ddffb1
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/brya/variants/craask/gpio.c
View File

@ -13,7 +13,7 @@ static const struct pad_config override_gpio_table[] = {
PAD_CFG_GPO_LOCK(GPP_B4, 1, LOCK_CONFIG), PAD_CFG_GPO_LOCK(GPP_B4, 1, LOCK_CONFIG),
/* D6 : WWAN_EN */ /* D6 : WWAN_EN */
PAD_CFG_GPO(GPP_D6, 1, DEEP), PAD_CFG_GPO(GPP_D6, 1, DEEP),
/* D7 : SRCCLKREQ1# ==> SSD_CLKREQ_ODL */ /* D7 : SRCCLKREQ2# ==> SSD_CLKREQ_ODL */
PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1), PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1),
/* D11 : EN_PP3300_SSD */ /* D11 : EN_PP3300_SSD */
PAD_CFG_GPO_LOCK(GPP_D11, 1, LOCK_CONFIG), PAD_CFG_GPO_LOCK(GPP_D11, 1, LOCK_CONFIG),

7
src/mainboard/google/brya/variants/craask/overridetree.cb
View File

@ -502,9 +502,12 @@ chip soc/intel/alderlake
probe SD_CARD SD_GL9750S probe SD_CARD SD_GL9750S
end end
device ref pcie_rp9 on device ref pcie_rp9 on
# Enable NVMe SSD PCIe 9-12 using clk 2 # Enable NVMe SSD PCIe 9-12 using clk_src1 and clk_req2 mapping to hardware
# design.Due to inconsistency between PMC firmware and FSP, we need to set
# clk_src to clk_req number, not same as hardware mapping in coreboot.Then
# swap correct setting to clk_src=1,clk_req=2 in mFIT.
register "pch_pcie_rp[PCH_RP(9)]" = "{ register "pch_pcie_rp[PCH_RP(9)]" = "{
.clk_src = 1, .clk_src = 2,
.clk_req = 2, .clk_req = 2,
.flags = PCIE_RP_LTR | PCIE_RP_AER, .flags = PCIE_RP_LTR | PCIE_RP_AER,
}" }"