GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

security/intel/stm: Remove check that can never be true 

STM_RSC_MEM_DESC defines rws_attributes as 3 bits, which can't be
greater than 7.

Found-by: Coverity Scan #1430578
Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I1efd007e96abd6d5d36f314752abfadffb0024d1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78619
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
This commit is contained in:
Martin Roth 2023-10-23 19:06:13 -06:00 committed by Shelley Chen
parent cc93db9435
commit face29cd50
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/security/intel/stm/SmmStm.c
View File

@ -354,9 +354,6 @@ static bool validate_resource(STM_RSC *resource_list, uint32_t num_entries)
if (resource->header.length != sizeof(STM_RSC_MEM_DESC)) if (resource->header.length != sizeof(STM_RSC_MEM_DESC))
return false; return false;
if (resource->mem.rwx_attributes > FULL_ACCS)
return false;
break; break;
case IO_RANGE: case IO_RANGE: