soc/amd/stoneyridge: factor out early AOAC initialization

Factor out enable_aoac_devices out of southbridge.c to aoac.c to align
Stoneyridge more with Picasso and Cezanne.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ied4d821138507639cad1794f6c5017b5873b761f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60140
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held 2021-12-15 19:35:00 +01:00
parent 4b9ac2c993
commit fbfb906081
3 changed files with 40 additions and 33 deletions

View File

@ -4,6 +4,7 @@ ifeq ($(CONFIG_SOC_AMD_STONEYRIDGE),y)
subdirs-y += ../../../cpu/amd/mtrr/ subdirs-y += ../../../cpu/amd/mtrr/
bootblock-y += aoac.c
bootblock-y += uart.c bootblock-y += uart.c
bootblock-y += BiosCallOuts.c bootblock-y += BiosCallOuts.c
bootblock-y += bootblock.c bootblock-y += bootblock.c

View File

@ -0,0 +1,39 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <amdblocks/aoac.h>
#include <delay.h>
#include <soc/aoac_defs.h>
#include <soc/southbridge.h>
#include <types.h>
/*
* Table of devices that need their AOAC registers enabled and waited
* upon (usually about .55 milliseconds). Instead of individual delays
* waiting for each device to become available, a single delay will be
* executed.
*/
static const unsigned int aoac_devs[] = {
FCH_AOAC_DEV_UART0 + CONFIG_UART_FOR_CONSOLE * 2,
FCH_AOAC_DEV_AMBA,
FCH_AOAC_DEV_I2C0,
FCH_AOAC_DEV_I2C1,
FCH_AOAC_DEV_I2C2,
FCH_AOAC_DEV_I2C3,
};
void enable_aoac_devices(void)
{
bool status;
int i;
for (i = 0; i < ARRAY_SIZE(aoac_devs); i++)
power_on_aoac_device(aoac_devs[i]);
/* Wait for AOAC devices to indicate power and clock OK */
do {
udelay(100);
status = true;
for (i = 0; i < ARRAY_SIZE(aoac_devs); i++)
status &= is_aoac_device_enabled(aoac_devs[i]);
} while (!status);
}

View File

@ -23,7 +23,6 @@
#include <soc/southbridge.h> #include <soc/southbridge.h>
#include <soc/smi.h> #include <soc/smi.h>
#include <soc/amd_pci_int_defs.h> #include <soc/amd_pci_int_defs.h>
#include <delay.h>
#include <soc/pci_devs.h> #include <soc/pci_devs.h>
#include <agesa_headers.h> #include <agesa_headers.h>
#include <soc/acpi.h> #include <soc/acpi.h>
@ -32,21 +31,6 @@
#include <soc/nvs.h> #include <soc/nvs.h>
#include <types.h> #include <types.h>
/*
* Table of devices that need their AOAC registers enabled and waited
* upon (usually about .55 milliseconds). Instead of individual delays
* waiting for each device to become available, a single delay will be
* executed.
*/
static const unsigned int aoac_devs[] = {
FCH_AOAC_DEV_UART0 + CONFIG_UART_FOR_CONSOLE * 2,
FCH_AOAC_DEV_AMBA,
FCH_AOAC_DEV_I2C0,
FCH_AOAC_DEV_I2C1,
FCH_AOAC_DEV_I2C2,
FCH_AOAC_DEV_I2C3,
};
static int is_sata_config(void) static int is_sata_config(void)
{ {
return !((SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) return !((SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE)
@ -152,23 +136,6 @@ const struct irq_idx_name *sb_get_apic_reg_association(size_t *size)
return irq_association; return irq_association;
} }
void enable_aoac_devices(void)
{
bool status;
int i;
for (i = 0; i < ARRAY_SIZE(aoac_devs); i++)
power_on_aoac_device(aoac_devs[i]);
/* Wait for AOAC devices to indicate power and clock OK */
do {
udelay(100);
status = true;
for (i = 0; i < ARRAY_SIZE(aoac_devs); i++)
status &= is_aoac_device_enabled(aoac_devs[i]);
} while (!status);
}
static void sb_enable_lpc(void) static void sb_enable_lpc(void)
{ {
u8 byte; u8 byte;