coreboot-kgpe-d16/src/mainboard/amd/persimmon
Paul Menzel 2e585a12a2 sb/amd/cimx/sb800: Get rid of power button device in coreboot
Apply commit d7b88dcb (mb/google/x86-boards: Get rid of power button
device in coreboot) to AMD Brazos boards [1]:

> As per the ACPI specification, there are two types of power button
> devices:
> 1. Fixed hardware power button
> 2. Generic hardware power button
>
> Fixed hardware power button is added by the OSPM if POWER_BUTTON flag
> is not set in FADT by the BIOS. This device has its programming model
> in PM1x_EVT_BLK. All ACPI compliant OSes are expected to add this
> power button device by default if the power button FADT flag is not
> set.
>
> On the other hand, generic hardware power button can be used by
> platforms if fixed register space cannot be used for the power button
> device. In order to support this, power button device object with HID
> PNP0C0C is expected to be added to ACPI tables. Additionally,
> POWER_BUTTON flag should be set to indicate the presence of control
> method for power button.
[..]
> This change gets rid of the generic hardware power button from all
> google mainboards and relies completely on the fixed hardware power
> button.

The same problem exists with the AMD Hudson devices in coreboot.

For AMD Hudson (2) and Yangtze based devices this was removed in commit
44f2fab8 (AMD hudson and yangtze boards: Let mainboard declare power
button) [2].

Two devices are detected.

    $ dmesg | grep Button
    [    0.209213] input: Power Button as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0C:00/input/input0
    [    0.209254] ACPI: Power Button [PWRB]
    [    0.209332] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input1
    [    0.209349] ACPI: Power Button [PWRF]

   $ sudo evtest
    No device specified, trying to scan all of /dev/input/event*
    Available devices:
    /dev/input/event0:      Power Button
    /dev/input/event1:      Power Button
    [..]

[1]: https://review.coreboot.org/5546
[2]: https://review.coreboot.org/27272

Change-Id: I0cbecb72f7e1bf3d051d3b7656c6af4d6f43b497
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/27496
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
2019-05-20 14:43:44 +00:00
..
acpi sb/amd/cimx/sb800: Get rid of power button device in coreboot 2019-05-20 14:43:44 +00:00
acpi_tables.c src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
BiosCallOuts.c
board_info.txt
buildOpts.c
cmos.layout
devicetree.cb AGESA fam14 boards: Clean up devicetree 2019-01-16 13:19:49 +00:00
dsdt.asl mb: Set coreboot as DSDT's manufacturer model ID 2018-11-23 11:00:40 +00:00
irq_tables.c
Kconfig mb/*/*/Kconfig: Remove useless comment 2018-11-28 13:53:51 +00:00
Kconfig.name
mainboard.c device/mmio.h: Add include file for MMIO ops 2019-03-04 15:57:39 +00:00
Makefile.inc
mptable.c src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
OemCustomize.c
OptionsIds.h
platform_cfg.h
romstage.c src: Remove unused include device/pnp_def.h 2019-02-07 08:53:07 +00:00