Felix Held 49be1a9346 Revert "cpu/x86/lapic: Unconditionally use CPUID leaf 0xb if available" ... This reverts commit ceaf959678. The AMD Picasso SoC doesn't support x2APIC and neither advertises the presence of its support via bit 21 in EAX of CPUID leaf 1 nor has the bit 10 in the APIC base address MSR 0x1b set, but it does have 0xd CPUID leaves, so just checking for the presence of that CPUID leaf isn't sufficient to be sure that EDX of the CPUID leaf 0xb will contain a valid APIC ID. In the case of Picasso EDX of the CPUID leaf 0xb returns 0 for all cores which causes coreboot to get stuck somewhere at the end of MP init. I'm not 100% sure if we should additionally check bit 21 in EAX of CPUID function 1 is set instead of adding back the is_x2apic_mode check. TEST=Mandolin with a Picasso SoC boots again. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: If1e3c55ce2d048b14c08e06bb79810179a87993d Reviewed-on: https://review.coreboot.org/c/coreboot/+/61776 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Christian Walter <christian.walter@9elements.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>		2022-02-10 10:23:22 +00:00
..
amd	cpu/x86/lapic: Move LAPIC configuration to MP init	2022-02-05 07:59:04 +00:00
armltd
intel	cpu/x86/lapic: Move LAPIC configuration to MP init	2022-02-05 07:59:04 +00:00
qemu-power8
qemu-x86	cpu/x86/lapic: Move LAPIC configuration to MP init	2022-02-05 07:59:04 +00:00
x86	Revert "cpu/x86/lapic: Unconditionally use CPUID leaf 0xb if available"	2022-02-10 10:23:22 +00:00
Kconfig	src/cpu: Remove unused symbols	2021-02-18 10:11:24 +00:00
Makefile.inc	src/cpu,soc/amd/common/block/cpu: Add preload_microcode	2021-11-29 20:39:32 +00:00