bcaaad1c55
This is a tool to help identify issues in coreboot's Kconfig structure and in how the Kconfig symbols are used in the coreboot codebase. It identifies a number of issues: - #ifdef used on Kconfig symbol of type bool, hex, or int. These are always defined. - #define CONFIG_ in the coreboot code - these should be reserved for Kconfig symbols. - Redefinition of Kconfig symbols in the code. - Use of IS_ENABLED() on non-bool kconfig symbols. - Use of IS_ENABLED() on values that are not kconfig symbols. - Attempts to find default values that will not set anything because of earlier default settings. This needs to be expanded significantly. - Kconfig expressions using symbols which are not defined. - Kconfig symbols that are defined but not used anywhere in the Kconfig structure or coreboot code. - Kconfig keywords used incorrectly. - Whitespace issues - Kconfig 'source' keyword issues -- sourcing non-existant directories -- sourcing Kconfig files multiple times -- sourcing non-existent files -- Kconfig files in the codebase that are never sourced Additionally, it can be used to help debug the Kconfig tree by putting all the files together into a single file with their source locations listed. Run from the coreboot directory: util/lint/kconfig_lint Change-Id: Ia53b366461698d949f17502e99265c1f3f3b1443 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: http://review.coreboot.org/12088 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org> |
||
---|---|---|
.. | ||
abuild | ||
acpi | ||
amdtools | ||
arm_boot_tools/mksunxiboot | ||
autoport | ||
bimgtool | ||
board_status | ||
broadcom | ||
cbfstool | ||
cbmem | ||
crossgcc | ||
dtd_parser | ||
ectool | ||
exynos | ||
fletcher | ||
genbuild_h | ||
genprof | ||
gitconfig | ||
ifdfake | ||
ifdtool | ||
inteltool | ||
intelvbttool | ||
ipqheader | ||
k8resdump | ||
kconfig | ||
lint | ||
msrtool | ||
nvidia | ||
nvramtool | ||
optionlist | ||
release | ||
rockchip | ||
romcc | ||
sconfig | ||
scripts | ||
showdevicetree | ||
spkmodem_recv | ||
superiotool | ||
uio_usbdebug | ||
vgabios | ||
viatool | ||
xcompile |