coreboot-kgpe-d16/src
Duncan Laurie 643daed6b5 vendorcode/google/chromeos: Use explicit zero check in ACPI code
The ASL 2.0 syntax for "!X" resolves to "LNot(X)" which will evaluate
the object as an integer and turn into a boolean.  This may not do the
right thing if the object is actually a string and it can lead to
unexpected behavior.

Instead be specific about the object type and check for zero or an
empty string depending on what is being returned.

This fixes an issue where some VPD keys were causing the search to
stop and miss subsequent entries.

Change-Id: I1688842964f9c2f81ca31073da9c2d71a8c81767
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32694
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
2019-05-09 15:34:53 +00:00
..
acpi
arch smbios: Walk over PCI devicetree to fill type 9 2019-05-07 16:05:53 +00:00
commonlib vboot: include vb2_sha.h when required 2019-05-09 06:32:44 +00:00
console Fix code that would trip -Wtype-limits 2019-05-06 10:32:15 +00:00
cpu cpu/intel/car/non-evict: Select NO_FIXED_XIP_ROM_SIZE 2019-04-25 15:56:28 +00:00
device device: ignore NONE devices behind bridge 2019-05-07 16:05:27 +00:00
drivers intel/fsp1_1: Drop remnants of `pei_data` 2019-05-07 15:59:10 +00:00
ec ec/lenovo/h8: Add VBOOT board support 2019-05-08 10:27:36 +00:00
include sconfig: Add SMBIOS type 9 entries 2019-05-07 16:04:56 +00:00
lib vboot: refactor OPROM code 2019-04-30 21:47:25 +00:00
mainboard mb/google/sarien: Move EC PTS/WAK function to mainboard 2019-05-09 00:25:44 +00:00
northbridge {src,util}: Remove duplicated includes 2019-05-07 16:15:56 +00:00
security vboot: include vb2_sha.h when required 2019-05-09 06:32:44 +00:00
soc Change the guard for bootblock_systemagent_early_init to ENV_BOOTBLOCK 2019-05-09 14:59:39 +00:00
southbridge sb/intel/bd82x6x: Fix flashconsole after lockdown 2019-05-07 16:04:07 +00:00
superio superio/fintek/f71808a: Add more optional ramstage registers 2019-05-01 00:09:57 +00:00
vendorcode vendorcode/google/chromeos: Use explicit zero check in ACPI code 2019-05-09 15:34:53 +00:00
Kconfig spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN 2019-05-06 10:31:38 +00:00