24d1d4b472
Here's the great news: From now on you don't have to worry about hitting the right io.h include anymore. Just forget about romcc_io.h and use io.h instead. This cleanup has a number of advantages, like you don't have to guard device/ includes for SMM and pre RAM anymore. This allows to get rid of a number of ifdefs and will generally make the code more readable and understandable. Potentially in the future some of the code in the io.h __PRE_RAM__ path should move to device.h or other device/ includes instead, but that's another incremental change. Change-Id: I356f06110e2e355e9a5b4b08c132591f36fec7d9 Signed-off-by: Stefan Reinauer <reinauer@google.com> Reviewed-on: http://review.coreboot.org/2872 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com> |
||
---|---|---|
.. | ||
cmos.layout | ||
devicetree.cb | ||
get_bus_conf.c | ||
irq_tables.c | ||
Kconfig | ||
mb_sysconf.h | ||
mptable.c | ||
README | ||
resourcemap.c | ||
romstage.c |
There are a number of outstanding issues: * I'm seeing toolchain issues. I can't get this tree to compile correctly with gcc 4.3 (32 bit) - there is an optimization issue where certain parts of the CBFS code execute very slowly. With gcc 3.4 (32 bit) that slowness disappears. This is probably not a problem related to this port specifically. * setting CONFIG_DEFAULT_CONSOLE_LOGLEVEL lower than 8 simply hangs the boot shortly after the warm reset triggered by the MCP55 code. I think this too might be a toolchain problem (but I see it on gcc 3.4 as well as 4.3). * during startup, the CPU cores talk through each other on serial for a while. Again, not an issue specific to this port. * to avoid very slow LZMA decompression I use this port with LZMA compression disabled in CBFS. I'm not sure what's causing this particular slowness. See also this thread: http://www.coreboot.org/pipermail/coreboot/2009-September/052107.html Ward, 2009-09-22