ac12ecd27a
Right now we perform direct pointer manipulation without any abstraction to read from and write to memory mapped flash chips. That makes it impossible to drive any flasher which does not mmap the whole chip. Using helper functions readb() and writeb() allows a driver for external flash programmers like Paraflasher to replace readb and writeb with calls to its own chip access routines. This patch has the additional advantage of removing lots of unnecessary casts to volatile uint8_t * and now-superfluous parentheses which caused poor readability. I used the semantic patcher Coccinelle to create this patch. The semantic patch follows: @@ expression a; typedef uint8_t; volatile uint8_t *b; @@ - *(b) = (a); + writeb(a, b); @@ volatile uint8_t *b; @@ - *(b) + readb(b) @@ type T; T b; @@ ( readb | writeb ) (..., - (T) - (b) + b ) In contrast to a sed script, the semantic patch performs type checking before converting anything. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: FENG Yu Ning <fengyuning1984@gmail.com> Tested-by: Joe Julian git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3971 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 |
||
|---|---|---|
| .. | ||
| ADLO | ||
| abuild | ||
| analysis | ||
| buildrom | ||
| dump_mmcr | ||
| flashrom | ||
| getpir | ||
| inteltool | ||
| k8resdump | ||
| lbtdump | ||
| mkelfImage | ||
| mptable | ||
| msrtool | ||
| newconfig | ||
| nrv2b | ||
| nvramtool | ||
| optionlist | ||
| options | ||
| resetcf | ||
| romcc | ||
| superiotool | ||
| vgabios | ||