b81362a82e
keyboard_disconnect was called without keyboard_init being called and in this case keyboard_havechar returns true because i8042_data_ready_ps2 is dereferencing uninitialized variable ps2_fifo from within fifo_is_empty causing keyboard_disconnect to be stuck in this while loop. while (keyboard_havechar()) keyboard_getchar(); BUG=b:80299098 TEST=Check if the normal mode path in depthcharge is not causing a hang Change-Id: I944b4836005c887a2715717dff2df1b5a220818e Signed-off-by: Hannah Williams <hannah.williams@intel.com> Reviewed-on: https://review.coreboot.org/26590 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com> |
||
---|---|---|
.. | ||
i8042 | ||
serial | ||
storage | ||
timer | ||
udc | ||
usb | ||
video | ||
Makefile.inc | ||
cbmem_console.c | ||
hid.c | ||
mouse_cursor.c | ||
nvram.c | ||
options.c | ||
pci.c | ||
speaker.c |