coreboot-kgpe-d16/src/mainboard/google/guybrush
Felix Held f8e440cadf mb/amd,google: use PAD_NF_SCI for GPIO_2 config in soc/amd based boards
When GPIO_2 was configured as PAD_NF with the WAKE_L function selected
the GPIO_2 override in soc_gpio_hook called soc_route_sci that wrote the
corresponding SCI mapping register, but didn't set up the SCI level and
trigger type, so that couldn't have worked on most of the boards. The
only boards where I think this was actually tested are the google/zork
ones and they configured GPIO_2 as PAD_SCI where the GPIO mux setting is
GPIO mode instead of the WAKE_L mode, but at least the SCI was
configured correctly. The new PAD_NF_SCI macro can configure both the
right GPIO mux setting and set up the SCI configuration correctly, so
use this new macro for the GPIO_2 pin. For test purposes I also added
the corresponding GPIO_2 configuration to amd/mandolin to see if the
affected registers end up having the expected value using the HDT
debugger to look at the registers, but didn't test the wake-up
functionality, since S3 resume isn't working on amd/mandolin yet.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Change-Id: Ic069e46b759fb6746645faccd254263c49a892d4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51756
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
2021-04-08 16:47:16 +00:00
..
spd mb/google/guybrush: Add generated LPDDR4x SPDs 2021-03-03 03:47:36 +00:00
variants mb/amd,google: use PAD_NF_SCI for GPIO_2 config in soc/amd based boards 2021-04-08 16:47:16 +00:00
board_info.txt
bootblock.c mb/google/guybrush: Temporary fix to set eSPI mux 2021-03-24 19:47:08 +00:00
chromeos.c mb/google/guybrush: Enable ACPI tables 2021-02-22 07:28:18 +00:00
chromeos.fmd
dsdt.asl mb/google/guybrush: Add ACPI support for Chrome EC 2021-03-13 02:37:30 +00:00
ec.c mb/google/guybrush: Enable eSPI VW SCI events 2021-03-15 16:20:45 +00:00
Kconfig mb/google/guybrush: Enable early EC Software Sync 2021-04-02 16:25:11 +00:00
Kconfig.name
mainboard.c mb/google/guybrush: Unmask eSPI keyboard IRQ 2021-04-08 06:48:37 +00:00
Makefile.inc soc/amd/cezanne: Pass DXIO and DDI Descriptors to FSP 2021-04-07 22:49:08 +00:00
port_descriptors.c mb/google/guybrush/port_descriptors: add dummy descriptors 2021-04-07 22:50:24 +00:00
smihandler.c mb/google/guybrush: Log mainboard events to elog 2021-03-11 01:14:32 +00:00
verstage.c mb/google/guybrush: Configure early GPIOs in earliest stage 2021-03-13 01:31:12 +00:00