apteryx
  • Joined on 2025-01-27
apteryx commented on issue speed-dreams/speed-dreams-code#49 2025-02-05 03:25:33 +01:00
Missing or bogus DT_RUNPATH entries in ELF binaries #15

To follow-up on https://gitlab.kitware.com/cmake/cmake/-/issues/26658#note_1621098, it appears CMake never set RPATH itself for installed binaries. So the project must set it themselves to the…

apteryx closed issue speed-dreams/speed-dreams-code#49 2025-02-02 07:21:17 +01:00
Missing or bogus DT_RUNPATH entries in ELF binaries #15
apteryx commented on issue speed-dreams/speed-dreams-code#49 2025-02-02 07:21:10 +01:00
Missing or bogus DT_RUNPATH entries in ELF binaries #15

I think this issue can now be closed. I'm still using -DSD_LIBDIR=bin in the Guix package but no other SD_* variables, as I now know these ideally shouldn't be messed with, and not seeing any…

apteryx commented on pull request speed-dreams/speed-dreams-code#53 2025-02-02 07:18:15 +01:00
Install a 'speed-dreams.desktop' launcher for UNIX systems.

Good idea! Oh, you are at FOSDEM? Neat, say hi to the Guix folks for me, and enjoy! :-).

apteryx deleted branch allow-setting-version-string from apteryx/speed-dreams-code 2025-02-01 15:26:54 +01:00
apteryx deleted branch fix-feesolid-missing-include from apteryx/speed-dreams-code 2025-02-01 15:26:27 +01:00
apteryx commented on pull request speed-dreams/speed-dreams-code#53 2025-02-01 15:24:13 +01:00
Install a 'speed-dreams.desktop' launcher for UNIX systems.

Having Icon= in the .desktop file point to a nonexistent file would not be fatal; it'd simply show a default dummy icon instead. For this reason, I think it may be better to leave this file…

apteryx commented on pull request speed-dreams/speed-dreams-code#53 2025-02-01 15:09:28 +01:00
Install a 'speed-dreams.desktop' launcher for UNIX systems.

I'd also rather avoid SD_BINDIR, but doing so would require changing a few things. As things stand, the speed-dreams-2 binary is installed to something computed by the [SD_INSTALL_FILES](http…

apteryx created pull request speed-dreams/speed-dreams-code#54 2025-02-01 13:54:39 +01:00
build: Allow setting version string at build.
apteryx pushed to allow-setting-version-string at apteryx/speed-dreams-code 2025-02-01 13:37:44 +01:00
90accd9d4c build: Allow setting version string at build.
apteryx created branch allow-setting-version-string in apteryx/speed-dreams-code 2025-02-01 13:37:43 +01:00
apteryx created pull request speed-dreams/speed-dreams-code#53 2025-02-01 13:03:59 +01:00
Install a 'speed-dreams.desktop' launcher for UNIX systems.
apteryx pushed to add-desktop-file at apteryx/speed-dreams-code 2025-02-01 13:02:55 +01:00
082f3d6956 Install a 'speed-dreams.desktop' launcher for UNIX systems.
apteryx created branch add-desktop-file in apteryx/speed-dreams-code 2025-02-01 13:02:54 +01:00
apteryx commented on pull request speed-dreams/speed-dreams-code#46 2025-02-01 13:02:08 +01:00
build: Fix missing FreeSOLID includes error.

I have just merged speed-dreams/speed-dreams-code#52 to fix one last standing issue with the CI/CD on forked repositories. @apteryx could you please rebase…

apteryx pushed to fix-feesolid-missing-include at apteryx/speed-dreams-code 2025-02-01 13:01:43 +01:00
7a3fa96a54 build: Do not hard-code /usr/${SD_LIBDIR}/lib in RUNPATH.
17aa56b432 INSTALL.txt: Delete doc for OPTION_3RDPARTY_SOLID build flag.
c8269cf804 build: Fix a missing FreeSOLID includes error.
c5b0a2b38a Merge pull request '.forgejo/workflows: Do not upload artifact on missing secrets' (#52) from xavi/speed-dreams-code:fix-missing-secrets into main
e6fd93e0f2 .forgejo/workflows: Do not upload artifact on missing secrets
Compare 5 commits »
apteryx commented on issue speed-dreams/speed-dreams-code#49 2025-02-01 08:58:22 +01:00
Missing or bogus DT_RUNPATH entries in ELF binaries #15

Ah, just read your old commit, seems the CPACK variables are not available in this context (CMake listfiles). That's bad. I've reported it to them, hoping to save you some time (https://gitlab.kit

apteryx commented on issue speed-dreams/speed-dreams-code#49 2025-02-01 08:49:42 +01:00
Missing or bogus DT_RUNPATH entries in ELF binaries #15

I see! Thanks for the background information. CPACK_PACKAGING_INSTALL_PREFIX is documented like this in CMake's manual:

25.7.7 CPACK_PACKAGING_INSTALL_PREFIX

---------------------------…

apteryx commented on pull request speed-dreams/speed-dreams-code#51 2025-02-01 08:33:19 +01:00
Do not assume Debian-specific CMAKE_INSTALL_RPATH

(for the record, this didn't break the execution, but it was flagged an unclean by the validate-runpath phase in Guix tooling)

apteryx commented on pull request speed-dreams/speed-dreams-code#51 2025-02-01 08:32:10 +01:00
Do not assume Debian-specific CMAKE_INSTALL_RPATH

LGTM!