speed-dreams/speed-dreams-code
6
0
Fork 1
Code Issues 8 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fix several issues with file setup #2

Merged
xavi merged 2 commits from issue-1 into main 2025-01-03 00:18:33 +01:00
Conversation 1 Commits 2 Files changed 2 +37 -14
xavi commented 2025-01-01 21:59:56 +01:00
Owner
Copy link

On fresh installations, Speed Dreams must copy a the files listed by GfDataDir()/user-files to the GfLocalDir. filesetup.cpp was recently refactored to allow this, but there were some issues with its implementation.

On fresh installations, Speed Dreams must copy a the files listed by `GfDataDir()/user-files` to the `GfLocalDir`. `filesetup.cpp` was recently refactored to allow this, but there were some issues with its implementation. - Requires https://forge.a-lec.org/speed-dreams/speed-dreams-data/pulls/1
xavi added 2 commits 2025-01-01 21:59:58 +01:00 
Now that the game ships without any driver by default, it is very likely
that simplix.xml does not exist on fresh installations. In fact, the
game already did not consider this as an error, so this was a leftover.
When GfFileSetup is called on a fresh installation, none of the
destination directories might exist.

On the other hand, robustness has been slightly improved by adding calls
to good() and is_open().
xavi commented 2025-01-03 00:18:22 +01:00
Author
Owner
Copy link

According to @leillo1975, this PR still does not fix #1, so it might be unrelated to it.

However, the fixes introduced by this PR are still required for the game work on a fresh installation, so it will be merged anyway.

According to @leillo1975, this PR still does not fix https://forge.a-lec.org/speed-dreams/speed-dreams-code/issues/1, so it might be unrelated to it. However, the fixes introduced by this PR are still required for the game work on a fresh installation, so it will be merged anyway.
xavi merged commit 316a1bc18b into main 2025-01-03 00:18:33 +01:00
xavi deleted branch issue-1 2025-01-03 00:18:33 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: speed-dreams/speed-dreams-code#2
No description provided.
Delete branch "issue-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?