GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/data_fabric: add missing data fabric device function 7 

The device function is missing in the PCI device table in the PPR, but
is present in the hardware. Verified on a Mandolin board with PCO APU.
The corresponding ticket for the PPR is DESPCSOC-6667.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ie91438bc905691d443ca4e7841549d1e3bca39ca
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51041
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held 2021-02-23 17:08:44 +01:00
parent 8240cc33ec
commit 0151b463c3
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/include/device/pci_ids.h
View File

@ -475,6 +475,7 @@
#define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4 0x15EC #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4 0x15EC
#define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5 0x15ED #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5 0x15ED
#define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6 0x15EE #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6 0x15EE
#define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7 0x15EF
#define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF0 0x1448 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF0 0x1448
#define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF1 0x1449 #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF1 0x1449
#define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF2 0x144A #define PCI_DEVICE_ID_AMD_FAM17H_MODEL60H_DF2 0x144A

3
src/soc/amd/picasso/data_fabric.c
View File

@ -115,6 +115,8 @@ static const char *data_fabric_acpi_name(const struct device *dev)
return "DFD5"; return "DFD5";
case PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6: case PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6:
return "DFD6"; return "DFD6";
case PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7:
return "DFD7";
default: default:
printk(BIOS_ERR, "%s: Unhandled device id 0x%x\n", __func__, dev->device); printk(BIOS_ERR, "%s: Unhandled device id 0x%x\n", __func__, dev->device);
} }
@ -137,6 +139,7 @@ static const unsigned short pci_device_ids[] = {
PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4, PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF4,
PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5, PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF5,
PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6, PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF6,
PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_DF7,
0 0
}; };