GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/broadwell/gma.c: Align `igd_setup_panel` with Haswell 

Rename it, add a print and factor out refclock value into a variable.

Change-Id: I7248e0b54cd6310cf74eadc5d976a8868cf822f2
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46688
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2020-10-23 14:49:36 +02:00
parent ebf800c538
commit 14cd17a5fb
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/soc/intel/broadwell/gma.c
View File

@ -281,7 +281,7 @@ int gtt_poll(u32 reg, u32 mask, u32 value)
return 0; return 0;
} }
static void igd_setup_panel(struct device *dev) static void gma_setup_panel(struct device *dev)
{ {
config_t *conf = config_of(dev); config_t *conf = config_of(dev);
u32 reg32; u32 reg32;
@ -326,7 +326,8 @@ static void igd_setup_panel(struct device *dev)
Reference clock is 24MHz. We can choose either a 16 Reference clock is 24MHz. We can choose either a 16
or a 128 step increment. Use 16 if we would have less or a 128 step increment. Use 16 if we would have less
than 100 steps otherwise. */ than 100 steps otherwise. */
const unsigned int hz_limit = 24 * 1000 * 1000 / 128 / 100; const unsigned int refclock = 24 * MHz;
const unsigned int hz_limit = refclock / 128 / 100;
unsigned int pwm_increment, pwm_period; unsigned int pwm_increment, pwm_period;
u32 south_chicken2; u32 south_chicken2;
@ -340,7 +341,12 @@ static void igd_setup_panel(struct device *dev)
} }
gtt_write(SOUTH_CHICKEN2, south_chicken2); gtt_write(SOUTH_CHICKEN2, south_chicken2);
pwm_period = 24 * 1000 * 1000 / pwm_increment / conf->gpu_pch_backlight_pwm_hz; pwm_period = refclock / pwm_increment / conf->gpu_pch_backlight_pwm_hz;
printk(BIOS_INFO,
"GMA: Setting backlight PWM frequency to %uMHz / %u / %u = %uHz\n",
refclock / MHz, pwm_increment, pwm_period,
DIV_ROUND_CLOSEST(refclock, pwm_increment * pwm_period));
/* Start with a 50% duty cycle. */ /* Start with a 50% duty cycle. */
gtt_write(BLC_PWM_PCH_CTL2, pwm_period << 16 | pwm_period / 2); gtt_write(BLC_PWM_PCH_CTL2, pwm_period << 16 | pwm_period / 2);
@ -532,7 +538,7 @@ static void igd_init(struct device *dev)
gtt_write(0xa008, rp1_gfx_freq << 24); gtt_write(0xa008, rp1_gfx_freq << 24);
/* Post VBIOS panel setup */ /* Post VBIOS panel setup */
igd_setup_panel(dev); gma_setup_panel(dev);
/* Initialize PCI device, load/execute BIOS Option ROM */ /* Initialize PCI device, load/execute BIOS Option ROM */
pci_dev_init(dev); pci_dev_init(dev);