GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/amd,google/zork: Move init_tables() call 

The semantics of pirq_setup() from previous platforms was to
only setup the global pointers for PIC and APIC tables, not
to create or modify the tables themselves.

Change-Id: Iaa7c31eed21432dc2b3fe6b32803bd2658fd5e2d
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50717
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Kyösti Mälkki 2021-02-15 13:08:19 +02:00
parent 2c7842407a
commit 32b99169a5
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/amd/bilby/mainboard.c
View File

@ -75,7 +75,6 @@ static void init_tables(void)
static void pirq_setup(void) static void pirq_setup(void)
{ {
init_tables();
intr_data_ptr = fch_apic_routing; intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing; picr_data_ptr = fch_pic_routing;
} }
@ -100,6 +99,7 @@ static void bilby_enable(struct device *dev)
{ {
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
init_tables();
/* Initialize the PIRQ data structures for consumption */ /* Initialize the PIRQ data structures for consumption */
pirq_setup(); pirq_setup();
} }

2
src/mainboard/amd/majolica/mainboard.c
View File

@ -81,7 +81,6 @@ static void init_tables(void)
static void pirq_setup(void) static void pirq_setup(void)
{ {
init_tables();
intr_data_ptr = fch_apic_routing; intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing; picr_data_ptr = fch_pic_routing;
} }
@ -94,6 +93,7 @@ static void majolica_enable(struct device *dev)
{ {
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
init_tables();
/* Initialize the PIRQ data structures for consumption */ /* Initialize the PIRQ data structures for consumption */
pirq_setup(); pirq_setup();
} }

2
src/mainboard/amd/mandolin/mainboard.c
View File

@ -75,7 +75,6 @@ static void init_tables(void)
static void pirq_setup(void) static void pirq_setup(void)
{ {
init_tables();
intr_data_ptr = fch_apic_routing; intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing; picr_data_ptr = fch_pic_routing;
} }
@ -100,6 +99,7 @@ static void mandolin_enable(struct device *dev)
{ {
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
init_tables();
/* Initialize the PIRQ data structures for consumption */ /* Initialize the PIRQ data structures for consumption */
pirq_setup(); pirq_setup();
} }

2
src/mainboard/google/zork/mainboard.c
View File

@ -104,7 +104,6 @@ static void init_tables(void)
/* PIRQ Setup */ /* PIRQ Setup */
static void pirq_setup(void) static void pirq_setup(void)
{ {
init_tables();
intr_data_ptr = fch_apic_routing; intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing; picr_data_ptr = fch_pic_routing;
} }
@ -202,6 +201,7 @@ static void zork_enable(struct device *dev)
{ {
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
init_tables();
/* Initialize the PIRQ data structures for consumption */ /* Initialize the PIRQ data structures for consumption */
pirq_setup(); pirq_setup();