GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vendorcode/amd/agesa: Remove -fno-zero-initialized-in-bss 

There are zero-initialized arrays within AGESA that were previously not
declared with CONST qualifier. Without this flag, such arrays would have
consumed valuable CAR space in romstage.

After adding CONST qualifiers these arrays have actually moved to
.rodata and removing the flag does not add anything to .bss.

TEST: see that BUILD_TIMELESS=1 results in the same binary.

Change-Id: I5b91deb1bf1b64bd9c88dc311db4e0b36df86c18
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64445
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Martin L Roth <gaumless@tutanota.com>
This commit is contained in:
Arthur Heymans 2022-05-18 09:30:03 +02:00 committed by Martin L Roth
parent 9e9dccb89f
commit 404188f80e
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/vendorcode/amd/agesa/Makefile.inc
View File

@ -9,7 +9,6 @@ subdirs-y += common
classes-y += libagesa
libagesa-y =
libagesa-generic-ccopts += -D__LIBAGESA__
libagesa-generic-ccopts += -fno-zero-initialized-in-bss
libagesa-generic-ccopts += $(AGESA_INC) $(AGESA_AUTOINCLUDES)
libagesa-generic-ccopts += -Wno-pragma-pack -Wno-unused-but-set-variable
libagesa-generic-ccopts += -Wno-implicit-fallthrough