mb/google/guybrush: Fix variant_has_pcie_wwan helper

variant_has_pcie_wwan helper returns true if gpp_bridge_2 PCIe engine is
enabled. On some variants, this engine is used by storage controllers.
Fix it by adding a weak override that returns no PCIe WWAN by default.

BUG=None
TEST=Build and boot to OS in Guybrush. Ensure that PCIe WWAN is
enumerated on boards where it is stuffed.

Change-Id: I07b9dd8fc5c8c3e1557f9268c1176d4a3cade1af
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58311
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Karthikeyan Ramasubramanian 2021-10-13 17:14:51 -06:00 committed by Felix Held
parent ba358a70d7
commit 7af90247be
3 changed files with 16 additions and 5 deletions

View File

@ -2,9 +2,6 @@
#include <baseboard/variants.h>
#include <device/device.h>
#include <fw_config.h>
#include <soc/iomap.h>
#include <soc/pci_devs.h>
WEAK_DEV_PTR(fpmcu);
@ -13,7 +10,7 @@ bool variant_has_fpmcu(void)
return is_dev_enabled(DEV_PTR(fpmcu));
}
bool variant_has_pcie_wwan(void)
bool __weak variant_has_pcie_wwan(void)
{
return is_dev_enabled(DEV_PTR(gpp_bridge_2));
return false;
}

View File

@ -1,7 +1,12 @@
# SPDX-License-Identifier: GPL-2.0-or-later
bootblock-y += gpio.c
bootblock-y += variant.c
romstage-y += gpio.c
romstage-y += variant.c
ramstage-y += gpio.c
ramstage-y += variant.c
subdirs-y += ./memory

View File

@ -0,0 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h>
#include <device/device.h>
bool variant_has_pcie_wwan(void)
{
return is_dev_enabled(DEV_PTR(gpp_bridge_2));
}