GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/common: Drop duplicate smi_set_eos() 

We have equivalent southbridge_smi_set_eos().

Change-Id: I03a48f0ec9efac2a220aa4ca502a5f504d78c585
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69668
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Kyösti Mälkki 2022-11-14 17:41:13 +02:00
parent 2e19aa153a
commit 95932ba9b7
3 changed files with 1 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/cpu/x86/smm/smm_module_handler.c
View File

@ -74,14 +74,6 @@ void io_trap_handler(int smif)
printk(BIOS_DEBUG, "Unknown function\n");
}
/**
* @brief Set the EOS bit
*/
static void smi_set_eos(void)
{
southbridge_smi_set_eos();
}
static u32 pci_orig;
/**
@ -196,7 +188,7 @@ asmlinkage void smm_handler_start(void *arg)
smi_release_lock();
/* De-assert SMI# signal to allow another SMI */
smi_set_eos();
southbridge_smi_set_eos();
}
RMODULE_ENTRY(smm_handler_start);

12
src/southbridge/intel/common/pmutil.c
View File

@ -176,18 +176,6 @@ void dump_tco_status(u32 tco_sts)
printk(BIOS_DEBUG, "\n");
}
/**
* @brief Set the EOS bit
*/
void smi_set_eos(void)
{
u8 reg8;
reg8 = read_pmbase8(SMI_EN);
reg8 |= EOS;
write_pmbase8(SMI_EN, reg8);
}
void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
{
int i;

1
src/southbridge/intel/common/pmutil.h
View File

@ -120,7 +120,6 @@ void dump_smi_status(u32 smi_sts);
u32 reset_smi_status(void);
void gpe0_mask(u32 clr, u32 set);
void alt_gpi_mask(u16 clr, u16 set);
void smi_set_eos(void);
void dump_alt_gp_smi_status(u16 alt_gp_smi_sts);
u16 reset_alt_gp_smi_status(void);
void dump_all_status(void);