GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/cbfstool/bpdt_formats: Fix memory leak issues 

The functions create_bpdt_hdr and create_cse_layout
in bpdt_1_6.c are defined to return pointers but
not integers as was previouly implemented.

Reported-by: Coverity(CID:1469323)
Reported-by: Coverity(CID:1469353)

Signed-off-by: Solomon Alan-Dei <alandei.solomon@gmail.com>
Change-Id: Idb78d94be7a75a25ad954f062e9e52b1f0b921dc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68986
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
This commit is contained in:
Solomon Alan-Dei 2022-10-29 08:30:23 -06:00 committed by Martin Roth
parent 37ccb2ce82
commit a2503fa2e9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/cbfstool/bpdt_formats/bpdt_1_6.c
View File

@ -69,7 +69,7 @@ static bpdt_hdr_ptr create_bpdt_hdr(void)
h->fit_tool_version.build = 0; h->fit_tool_version.build = 0;
h->fit_tool_version.hotfix = 0; h->fit_tool_version.hotfix = 0;
return 0; return h;
} }
static void print_bpdt_hdr(const bpdt_hdr_ptr ptr) static void print_bpdt_hdr(const bpdt_hdr_ptr ptr)
@ -159,7 +159,7 @@ static cse_layout_ptr create_cse_layout(const struct region *r)
l->bp3_size = r[BP3].size; l->bp3_size = r[BP3].size;
l->checksum = 0; /* unused */ l->checksum = 0; /* unused */
return 0; return l;
} }
static void print_cse_layout(const cse_layout_ptr ptr) static void print_cse_layout(const cse_layout_ptr ptr)