GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarify that _ROM_RUN Kconfig options control if ROMs are run by coreboot 

Also clarify that enabling these options is generally not desirable if
using SeaBIOS as payload since the option ROMs are run by SeaBIOS with
more complete BIOS interrupt services available than coreboot.

Change-Id: Ic4a45c351a4933aedad08d70a088eab04ca35b05
Signed-off-by: Peter Stuge <peter@stuge.se>
Reviewed-on: http://review.coreboot.org/1636
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Peter Stuge 2012-10-27 13:45:51 +02:00 committed by Patrick Georgi
parent 892d8d2c58
commit b6fa47c639
1 changed files with 33 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/devices/Kconfig
View File

@ -23,37 +23,60 @@ config VGA_ROM_RUN
bool "Run VGA Option ROMs" bool "Run VGA Option ROMs"
default y default y
help help
Execute VGA Option ROMs, if found. This is required to enable Execute VGA Option ROMs in coreboot if found. This is required
PCI/AGP/PCI-E video cards. to enable PCI/AGP/PCI-E video cards when not using a SeaBIOS
payload.
When using a SeaBIOS payload it runs all option ROMs with much
more complete BIOS interrupt services available than coreboot,
which some option ROMs require in order to function correctly.
If unsure, say N when using SeaBIOS as payload, Y otherwise.
config S3_VGA_ROM_RUN config S3_VGA_ROM_RUN
bool "Re-run VGA Option ROMs on S3 resume" bool "Re-run VGA Option ROMs on S3 resume"
default y default y
depends on VGA_ROM_RUN && HAVE_ACPI_RESUME depends on VGA_ROM_RUN && HAVE_ACPI_RESUME
help help
Execute VGA Option ROMs when coming out of an S3 resume. Execute VGA Option ROMs in coreboot when resuming from S3 suspend.
When using a SeaBIOS payload it runs all option ROMs with much
more complete BIOS interrupt services available than coreboot,
which some option ROMs require in order to function correctly.
If unsure, say N when using SeaBIOS as payload, Y otherwise.
config PCI_ROM_RUN config PCI_ROM_RUN
bool "Run non-VGA Option ROMs" bool "Run non-VGA Option ROMs"
default y default y
help help
Execute non-VGA PCI Option ROMs, if found. Execute non-VGA PCI Option ROMs in coreboot if found.
Examples include IDE/SATA controller Option ROMs and Option ROMs Examples include IDE/SATA controller Option ROMs and Option ROMs
for network cards (NICs). for network cards (NICs).
When using a SeaBIOS payload it runs all option ROMs with much
more complete BIOS interrupt services available than coreboot,
which some option ROMs require in order to function correctly.
If unsure, say N when using SeaBIOS as payload, Y otherwise.
config ON_DEVICE_ROM_RUN config ON_DEVICE_ROM_RUN
bool "Run Option ROMs on PCI devices" bool "Run Option ROMs on PCI devices"
default y default y
help help
Execute Option ROMs that are stored on PCI/PCIe/AGP devices. Execute Option ROMs stored on PCI/PCIe/AGP devices in coreboot.
If disabled, only Option ROMs stored in CBFS will be executed. If If disabled, only Option ROMs stored in CBFS will be executed by
you are concerned about security, you might want to disable this coreboot. If you are concerned about security, you might want to
option, but it might leave your system in a state of degraded disable this option, but it might leave your system in a state of
functionality. degraded functionality.
If unsure, say Y When using a SeaBIOS payload it runs all option ROMs with much
more complete BIOS interrupt services available than coreboot,
which some option ROMs require in order to function correctly.
If unsure, say N when using SeaBIOS as payload, Y otherwise.
choice choice
prompt "Option ROM execution type" prompt "Option ROM execution type"