coreboot-kgpe-d16/src/southbridge/amd
Jacob Garber 52f3bd158a sb/amd/sb800: Remove bit shift that does nothing
This bit shift attempts to set bits 8 and 9 of the byte variable (counting
from 0). However, as the name suggests, this variable is only 8 bits
wide, so the shift does nothing. Reading section 7.5 of the
AMD SB800-Series Southbridges Register Programming Requirements manual,
bits 8 and 9 are already set by default, so we can remove the bit shift.
(Alternatively, we could try setting the corresponding bits one byte
higher in 0xF1 if needed.)

Change-Id: I645236441e02925ee01339378d213cb343027363
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1229582
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34395
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
2019-07-19 10:01:50 +00:00
..
agesa src: Make implicit fall throughs explicit 2019-07-19 09:57:54 +00:00
amd8111 src: Use include <console/console.h> when appropriate 2019-04-23 10:01:21 +00:00
amd8132
cimx src: Make implicit fall throughs explicit 2019-07-19 09:57:54 +00:00
common src/southbridge/amd: Remove unused variables 2019-04-25 15:54:35 +00:00
pi arch/x86: Avoid HAVE_SMI_HANDLER conditional with smm-class 2019-07-09 12:43:35 +00:00
rs780 sb/amd/rs780: Remove dead assignment 2019-06-28 19:21:42 +00:00
sb700 src: Make implicit fall throughs explicit 2019-07-19 09:57:54 +00:00
sb800 sb/amd/sb800: Remove bit shift that does nothing 2019-07-19 10:01:50 +00:00
sr5650 sb/amd/sr5650: Add fine-grained bounds checking 2019-07-17 16:06:46 +00:00