coreboot-kgpe-d16/util/cbfstool
Martin Roth f183a85932 util/cbfstool: Check for NULL before dereference
Fixed coverity issue: 1302455 - Dereference null return value

Change-Id: I59b908adc4d35f08fda8e4ad3f806714f2caeb65
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/22900
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
2017-12-20 16:35:13 +00:00
..
console Remove extra newlines from the end of all coreboot files. 2016-07-31 18:19:33 +02:00
flashmap Rename __attribute__((packed)) --> __packed 2017-07-13 19:45:59 +00:00
lz4 Rename __attribute__((packed)) --> __packed 2017-07-13 19:45:59 +00:00
lzma
EXAMPLE
Makefile util/cbfstool: Add cbfs-compression-tool 2017-01-12 21:40:25 +01:00
Makefile.inc util/cbfstool: Fix build with armv7-eabi cross compiler 2017-08-02 09:55:11 +00:00
ProcessorBind.h Remove extra newlines from the end of all coreboot files. 2016-07-31 18:19:33 +02:00
README.fmaptool
cbfs-mkpayload.c util/cbfstool: demote FV handling errors to debug 2017-07-07 09:01:29 +00:00
cbfs-mkstage.c util: change coreboot to lowercase 2017-06-27 18:26:01 +00:00
cbfs-payload-linux.c util/cbfstool: Fix to build with latest llvm 2017-01-04 21:37:39 +01:00
cbfs.h cbfstool: Add '-p' option for padding 2017-12-08 16:05:52 +00:00
cbfs_image.c cbfstool: Print compression algorithm 2017-10-28 09:39:59 +00:00
cbfs_image.h util/cbfstool: Add "truncate" command 2017-10-10 15:16:17 +00:00
cbfs_sections.c
cbfs_sections.h
cbfscomptool.c cbfscomptool: fix display of time_t 2017-05-27 01:45:17 +02:00
cbfstool.c util/cbfstool: calculate cbfs file size for xip stages 2017-12-19 22:28:20 +00:00
coff.h
common.c util/cbfstool: Handle error condition more carefully 2016-12-15 22:58:38 +01:00
common.h util/cbfstool: Add cbfs-compression-tool 2017-01-12 21:40:25 +01:00
compiler.h util/cbmem, util/cbfstool: resolve macro errors on FreeBSD 2017-08-11 18:54:23 +00:00
compress.c cbfs: Add LZ4 in-place decompression support for pre-RAM stages 2016-02-22 21:38:37 +01:00
default-x86.fmd console/flashsconsole: Add spi flash console for debugging 2017-06-04 18:44:56 +02:00
default.fmd console/flashsconsole: Add spi flash console for debugging 2017-06-04 18:44:56 +02:00
elf.h
elfheaders.c util/cbfstool: calculate cbfs file size for xip stages 2017-12-19 22:28:20 +00:00
elfparsing.h util/cbfstool: calculate cbfs file size for xip stages 2017-12-19 22:28:20 +00:00
fit.c Rename __attribute__((packed)) --> __packed 2017-07-13 19:45:59 +00:00
fit.h
flashmap_tests.c
fmap_from_fmd.c
fmap_from_fmd.h
fmaptool.c fmaptool: Make base offsets absolute in fmap_config.h 2016-06-21 17:14:27 +02:00
fmd.c util/cbfstool: avoid memleaks and off-by-ones 2017-03-20 20:05:09 +01:00
fmd.h
fmd_parser.c_shipped
fmd_parser.h_shipped
fmd_parser.y
fmd_scanner.c_shipped fmaptool: Accept hex values with uppercase letters 2016-07-04 12:17:51 +02:00
fmd_scanner.h_shipped fmaptool: Accept hex values with uppercase letters 2016-07-04 12:17:51 +02:00
fmd_scanner.l fmaptool: Accept hex values with uppercase letters 2016-07-04 12:17:51 +02:00
fv.h
ifwitool.c Rename __attribute__((packed)) --> __packed 2017-07-13 19:45:59 +00:00
linux.h Rename __attribute__((packed)) --> __packed 2017-07-13 19:45:59 +00:00
linux_trampoline.S
linux_trampoline.c
linux_trampoline.h
option.h
partitioned_file.c util/cbfstool: Check for NULL before dereference 2017-12-20 16:35:13 +00:00
partitioned_file.h cbfstool: accept read-only files when possible 2016-01-19 18:14:44 +01:00
rmodtool.c
rmodule.c util/cbfstool: Include commonlib/helpers.h in common.h 2016-05-28 08:48:45 +02:00
rmodule.h
swab.h cbfstool: Add header file for ntohl & htonl on Apple 2016-01-20 16:10:20 +01:00
xdr.c

README.fmaptool

Flashmap descriptors in coreboot
================================
Flashmap (https://code.google.com/p/flashmap) is a binary format for representing the layout of
flash chips. Since coreboot is starting to use a "partition" of this format to describe the flash
chip layout---both at runtime and when flashing a new image onto a chip---, the project needed a
reasonably expressive plaintext format for representing such sections in the source tree. Our
solution is the fmd ("flashmap descriptor") language, and the files in this directory contain a
scanner, parser, semantic analyser, and flashmap converter. Here's an informal language description:

# <line comment>
<image name>[@<memory-mapped address>] <image size> {
	<section name>[@<offset from start of image>] [<section size>] [{
		<subsection name>[@<offset from start of parent section>] [<subsection size>] [{
			# Sections can be nested as deeply as desired
			<subsubsection name>[(CBFS)][@...] [...] [{...}]
		}]
		[<subsection name>[(CBFS)][@...] [...] [{...}]]
		# There can be many subsections at each level of nesting: they will be inserted
		# sequentially, and although gaps are allowed, any provided offsets are always
		# relative to the closest parent node's and must be strictly increasing with neither
		# overlapping nor degenerate-size sections.
	}]
}

Note that the above example contains a few symbols that are actually metasyntax, and therefore have
neither meaning nor place in a real file. The <.*> s indicate placeholders for parameters:
 - The names are strings, which are provided as single-word---no whitespace---groups of
   syntactically unimportant symbols (i.e. everything except @, {, and }): they are not surrounded
   by quotes or any other form of delimiter.
 - The other fields are nonnegative integers, which may be given as decimal or hexadecimal; in
   either case, a K, M, or G may be appended---without intermediate whitespace---as a multiplier.
 - Comments consist of anything one manages to enter, provided it doesn't start a new line.
The [.*] s indicate that a portion of the file could be omitted altogether:
 - Just because something is noted as optional doesn't mean it is in every case: the answer might
   actually depend on which other information is---or isn't---provided.
 - In particular, it is only legal to place a (CBFS) annotation on a leaf section; that is, choosing
   to add child sections excludes the possibility of putting a CBFS in their parent. Such
   annotations are only used to decide where CBFS empty file headers should be created, and do not
   result in the storage of any additional metadata in the resulting FMAP section.
Additionally, it's important to note these properties of the overall file and its values:
 - Other than within would-be strings and numbers, whitespace is ignored. It goes without saying
   that such power comes with responsibility, which is why this sentence is here.
 - Although the .*section names must be globally unique, one of them may---but is not required to---
   match the image name.
 - It is a syntax error to supply a number---besides 0---that begins with the character 0, as there
   is no intention of adding octals to the mix.
 - The image's memory address should be present on---and only on---layouts for memory-mapped chips.
 - Although it may be evident from above, all .*section offsets are relative only to the immediate
   parent. There is no way to include an absolute offset (i.e. from the beginning of flash), which
   means that it is "safe" to reorder the .*section s within a particular level of nesting, as long
   as the change doesn't cause their positions and sizes to necessitate overlap or zero sizes.
 - A .*section with omitted offset is assumed to start at as low a position as possible---with no
   consideration of alignment---and one with omitted size is assumed to fill the remaining space
   until the next sibling or before the end of its parent.
 - It's fine to omit any .*section 's offset, size, or both, provided its position and size are
   still unambiguous in the context of its *sibling* sections and its parent's *size*. In
   particular, knowledge of one .*section 's children or the .*section s' common parent's siblings
   will not be used for this purpose.
 - Although .*section s are not required to have children, the flash chip as a whole must have at
   least one.
 - Though the braces after .*section s may be omitted for those that have no children, if they are
   present, they must contain at least one child.

PL people and sympathizers may wish to examine the formal abstract syntax and context-free grammar,
which are located in fmd_scanner.l and fmd_scanner.y, respectively. Those interested in the
algorithm used to infer omitted values will feel at home in fmd.c, particularly near the definition
of validate_and_complete_info().