coreboot-kgpe-d16/src
Furquan Shaikh 38f3ffad3f security/tpm/tspi: Set return type of tcpa_log_add_table_entry as void
Change f849972 (security/vboot: Enable TCPA log extension) enabled
support for adding TCPA log to CBMEM. However, if CBMEM is not online,
this function doesn't do anything and returns early. This condition is
not really a valid error condition as it depends on when the call to
tcpa_log_add_table_entry is made. Since tcpa_log_add_table_entry
returns -1 when cbmem is not online, tpm_extend_pcr prints an error
message with prefix "ERROR:". This can confuse any scripts trying to
catch errors in boot flow.

This CL makes the following changes:
1. Removes the print in tpm_extend_pcr since tcpa_log_add_table_entry
already prints out appropriate ERROR messages in case of failure to
add log entry.
2. Since the return value of tcpa_log_add_table_entry is not used
anymore, return type for tcpa_log_add_table_entry is changed to void.

BUG=b:112030232

Change-Id: I32d313609a3e57845e67059b3747b81b5c8adb2a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/27757
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
2018-07-31 21:58:43 +00:00
..
acpi arch/x86: Add common AMD ACPI hardware definitions 2017-11-10 19:15:38 +00:00
arch riscv: fix issues (timestrap & PRIu64) 2018-07-31 10:07:57 +00:00
commonlib security/tpm: Use unique CBMEM names for TCPA logs 2018-07-30 15:47:23 +00:00
console arch/x86: Drop leftover ROMCC console support 2018-06-08 03:31:12 +00:00
cpu nb/intel/gm45: Use common code for SMM in TSEG 2018-07-30 19:11:00 +00:00
device pnp_device: don't treat missing PNP_MSC devicetree entry as error 2018-07-29 15:06:41 +00:00
drivers drivers/i2c/da7219: Allow disabling micbias-pulse feature 2018-07-30 18:45:44 +00:00
ec ec/lenovo/h8/acpi: Fix ACPI error in _INI 2018-07-30 18:59:51 +00:00
include cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x 2018-07-30 19:03:27 +00:00
lib util/cbmem: Add cbmem TCPA log support 2018-07-28 16:58:30 +00:00
mainboard mb/google/octopus: add lpddr4 skus for new memory sources 2018-07-31 19:16:45 +00:00
northbridge x4x/raminit_ddr23: use MCHBAR AND/OR/AND_OR macros [1/2] 2018-07-30 20:44:37 +00:00
security security/tpm/tspi: Set return type of tcpa_log_add_table_entry as void 2018-07-31 21:58:43 +00:00
soc src/soc/amd/stoneyridge: Remove IMC support 2018-07-31 00:46:07 +00:00
southbridge nb/intel/gm45: Use common code for SMM in TSEG 2018-07-30 19:11:00 +00:00
superio sio/smsc/fdc37n972: add missing pnp_conf_mode field to ops struct 2018-07-26 14:22:28 +00:00
vendorcode src/vendorcode/amd/pi/00670F00: Remove IMC support 2018-07-31 00:46:25 +00:00
Kconfig Kconfig: Make the EM100 config option common 2018-07-16 07:41:14 +00:00